Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iChain Mainnet #3560

Merged
merged 40 commits into from
Oct 24, 2023
Merged

Add iChain Mainnet #3560

merged 40 commits into from
Oct 24, 2023

Conversation

iChainBlock
Copy link
Contributor

No description provided.

@iChainBlock
Copy link
Contributor Author

@ligi Trust you are having a good day. Please let us know what is wrong with our logo json file ichain.json, we are following all the rules, and we checked successful merged requests to make sure we are following all the checks right. The check is always refusing our logo even we tried different formats and we are exporting these formats from our Canva account, please advise.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the prettier to format your json according to the style defined here
e.g. run npx prettier --write _data/*/*.json

@iChainBlock
Copy link
Contributor Author

Please run the prettier to format your json according to the style defined here e.g. run npx prettier --write _data/*/*.json

Thank you, I did that now.

@iChainBlock iChainBlock requested a review from ligi October 5, 2023 23:41
@iChainBlock
Copy link
Contributor Author

Please run the prettier to format your json according to the style defined here e.g. run npx prettier --write _data/*/*.json

@ligi Please let me know what is the issue now, we still have one check failing.

Thank you

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not resolve your CID with ipfs get in a reasonable time - and before having a back and forth here I require you to put it in iconDownload. Before this back and forth did cost me a lot of time that I do not have.

@iChainBlock
Copy link
Contributor Author

I could not resolve your CID with ipfs get in a reasonable time - and before having a back and forth here I require you to put it in iconDownload. Before this back and forth did cost me a lot of time that I do not have.

@ligi We value your time and appreciate your support, we are sorry to cost you that much time, now we added the file to iconsDownload, hope this works, we changed the file extension to binary as the other files in that directory.

Thank you so much for your continues follow up and support.

Regards

@iChainBlock
Copy link
Contributor Author

@ligi Hope you are doing well, I removed the icon for now, I will add it later when I get the correct icon from our designer. Thank you so much for you cooperation and support.

@iChainBlock
Copy link
Contributor Author

@ligi Hope you are doing well, Please note that we removed the logo for now in order to bypass the issue, we need your action please. Thank you so much

@jnut321

This comment was marked as spam.

@iChainBlock
Copy link
Contributor Author

@ligi Hope you are doing well, I saw that all workflows passed, but when I updated the branch it required approval again, thank you so much. Best Regards

@ligi ligi merged commit 55083aa into ethereum-lists:master Oct 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants