Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(derive): Online Module Touchups #265

Merged
merged 1 commit into from
Jun 16, 2024
Merged

chore(derive): Online Module Touchups #265

merged 1 commit into from
Jun 16, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Jun 16, 2024 •
edited
Loading

Description

Cleans up the online module.

@refcell refcell changed the title chore(derive): online module touchups chore(derive): Online Module Touchups Jun 16, 2024
@refcell Graphite App
Copy link
Collaborator Author

refcell commented Jun 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell requested a review from clabby June 16, 2024 20:18
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate labels Jun 16, 2024 — with Graphite App
@refcell refcell self-assigned this Jun 16, 2024
@refcell refcell marked this pull request as ready for review June 16, 2024 20:19
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0b13877). Learn more about missing BASE report.

Files Patch % Lines
crates/derive/src/online/beacon_client.rs 0.0% 9 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added this pull request to the merge queue Jun 16, 2024
Merged via the queue into main with commit 3fe24f4 Jun 16, 2024
14 checks passed
This was referenced Jun 16, 2024
Closed
Closed
Merged
@clabby clabby deleted the refcell/online-touchups branch July 2, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Milestone
Phase 2: Kona Derivation Pipeline
Development

Successfully merging this pull request may close these issues.
3 participants
@refcell @codecov-commenter @clabby