optimism: set chain-ID of pre-bedrock relayed txs #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, here is op-erigon's fix: testinprod-io/op-erigon#14 for this exact same issue. |
ajsutton
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-bedrock relayed txs do not have a signature. When served in the RPC the chain ID should not be computed from the signature values, but rather be set from the chain config, to ensure it's stated correctly in the RPC result. The legacy l2geth didn't include the chain ID in the response at all, but we do want it to be compatible with the latest API spec that includes it.
Tests
Fixes an API result of legacy data, may need a new testing strategy for l2geth data, but this change is simple enough that we can test-run it with:
Which previously recorded
"chainId":"0x7fffffffffffffee"but should now be"chainId":"0xa"Metadata
CLI-4072
TODOs