Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-chain-ops: Canyon checker script #7903

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

trianglesphere
Copy link
Contributor

Description

This tests the following features of Canyon

  1. The receipt hash change
  2. The 1559 Parameter change (note: if the basefee is too low this check may not properly report)
  3. Check for withdrawals (to indicate Shapella has activated)
  4. Check for the create2Deployer code hash

One change to eth.BlockInfo to expose the gas limit. TBH I could actually remove it b/c I also dial ethclient in addition to sources.L1Client.

Tests

Manually tested against the devnet.

Metadata

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just worth clarifying the l1 vs l2 naming.

op-chain-ops/cmd/check-canyon/main.go Outdated Show resolved Hide resolved
op-chain-ops/cmd/check-canyon/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Nov 7, 2023

Semgrep found 1 nil-check-after-call finding:

Potential p2pmetrics nil dereference when NewBandwidthCounter is called

Ignore this finding from nil-check-after-call.

Semgrep found 2 todos_require_linear findings:

  • op-node/rollup/derive/channel_out.go: L83, L70

Please create a GitHub ticket for this TODO.

Ignore this finding from todos_require_linear.

@trianglesphere trianglesphere force-pushed the jg/canyon_checker branch 2 times, most recently from a45a933 to 86af5b5 Compare November 7, 2023 01:55
@trianglesphere trianglesphere added this pull request to the merge queue Nov 7, 2023
Merged via the queue into develop with commit 5ebbc08 Nov 7, 2023
59 checks passed
@trianglesphere trianglesphere deleted the jg/canyon_checker branch November 7, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing Plan for Canyon Network Upgrade
2 participants