From 95a2cf44bafaf3983251ef890087a3abd9c9306a Mon Sep 17 00:00:00 2001 From: William Entriken Date: Tue, 12 Nov 2019 10:33:23 -0500 Subject: [PATCH 1/2] Fix spelling of GitHub --- .bundle/config | 2 ++ EIPS/eip-1.md | 6 +++--- EIPS/eip-1155.md | 2 +- EIPS/eip-1261.md | 6 +++--- EIPS/eip-1319.md | 2 +- EIPS/eip-1470.md | 2 +- EIPS/eip-1761.md | 4 ++-- EIPS/eip-2135.md | 4 ++-- EIPS/eip-2255.md | 2 +- EIPS/eip-233.md | 2 +- PULL_REQUEST_TEMPLATE.md | 2 +- README.md | 6 +++--- 12 files changed, 21 insertions(+), 19 deletions(-) create mode 100644 .bundle/config diff --git a/.bundle/config b/.bundle/config new file mode 100644 index 00000000000000..2369228816d467 --- /dev/null +++ b/.bundle/config @@ -0,0 +1,2 @@ +--- +BUNDLE_PATH: "vendor/bundle" diff --git a/EIPS/eip-1.md b/EIPS/eip-1.md index 27f86ba5ce0d02..ecd42fd7bc114c 100644 --- a/EIPS/eip-1.md +++ b/EIPS/eip-1.md @@ -56,7 +56,7 @@ In addition to making sure your idea is original, it will be your role as the au For Core EIPs, given that they require client implementations to be considered **Final** (see "EIPs Process" below), you will need to either provide an implementation for clients or convince clients to implement your EIP. -The best way to get client implementers to review your EIP is to present it on an AllCoreDevs call. You can request to do so by posting a comment linking your EIP on an [AllCoreDevs agenda Github Issue]. +The best way to get client implementers to review your EIP is to present it on an AllCoreDevs call. You can request to do so by posting a comment linking your EIP on an [AllCoreDevs agenda GitHub Issue]. The AllCoreDevs call serve as a way for client implementers to do three things. First, to discuss the technical merits of EIPs. Second, to gauge what other clients will be implementing. Third, to coordinate EIP implementation for network upgrades. @@ -249,7 +249,7 @@ For each new EIP that comes in, an editor does the following: - Read the EIP to check if it is ready: sound and complete. The ideas must make technical sense, even if they don't seem likely to get to final status. - The title should accurately describe the content. -- Check the EIP for language (spelling, grammar, sentence structure, etc.), markup (Github flavored Markdown), code style +- Check the EIP for language (spelling, grammar, sentence structure, etc.), markup (GitHub flavored Markdown), code style If the EIP isn't ready, the editor will send it back to the author for revision, with specific instructions. @@ -314,7 +314,7 @@ See [the revision history for further details](https://github.com/ethereum/EIPs/ [Bitcoin's BIP-0001]: https://github.com/bitcoin/bips [Python's PEP-0001]: https://www.python.org/dev/peps/ [the Ethereum Magicians forum]: https://ethereum-magicians.org/ -[AllCoreDevs agenda Github Issue]: https://github.com/ethereum/pm/issues +[AllCoreDevs agenda GitHub Issue]: https://github.com/ethereum/pm/issues ## Copyright diff --git a/EIPS/eip-1155.md b/EIPS/eip-1155.md index a35e508c6070f7..2065e432dccfa9 100644 --- a/EIPS/eip-1155.md +++ b/EIPS/eip-1155.md @@ -700,7 +700,7 @@ Another simple way to represent non-fungibles is to allow a maximum value of 1 f - [The Sandbox - Dual ERC-1155/721 Contract](https://github.com/pixowl/thesandbox-contracts/tree/master/src/Asset) **Articles & Discussions** -- [Github - Original Discussion Thread](https://github.com/ethereum/EIPs/issues/1155) +- [GitHub - Original Discussion Thread](https://github.com/ethereum/EIPs/issues/1155) - [ERC-1155 - The Crypto Item Standard](https://blog.enjincoin.io/erc-1155-the-crypto-item-standard-ac9cf1c5a226) - [Here Be Dragons - Going Beyond ERC-20 and ERC-721 To Reduce Gas Cost by ~80%](https://medium.com/horizongames/going-beyond-erc20-and-erc721-9acebd4ff6ef) - [Blockonomi - Ethereum ERC-1155 Token Perfect for Online Games, Possibly More](https://blockonomi.com/erc1155-gaming-token/) diff --git a/EIPS/eip-1261.md b/EIPS/eip-1261.md index 132383e5eee994..425e38cb0ee53e 100644 --- a/EIPS/eip-1261.md +++ b/EIPS/eip-1261.md @@ -295,9 +295,9 @@ One can think of the set of MVTs as identifying a user, and you cannot split the The assign and revoke functions' documentation only specify conditions when the transaction MUST throw. Your implementation MAY also throw in other situations. This allows implementations to achieve interesting results: -- **Disallow additional memberships after a condition is met** — Sample contract available on Github -- **Blacklist certain address from receiving MV tokens** — Sample contract available on Github -- **Disallow additional memberships after a certain time is reached** — Sample contract available on Github +- **Disallow additional memberships after a condition is met** — Sample contract available on GitHub +- **Blacklist certain address from receiving MV tokens** — Sample contract available on GitHub +- **Disallow additional memberships after a certain time is reached** — Sample contract available on GitHub - **Charge a fee to user of a transaction** — require payment when calling `assign` and `revoke` so that condition checks from external sources can be made **ERC-173 Interface** diff --git a/EIPS/eip-1319.md b/EIPS/eip-1319.md index e51788eefd4ee0..20121871ff7289 100644 --- a/EIPS/eip-1319.md +++ b/EIPS/eip-1319.md @@ -170,7 +170,7 @@ Registries may offer more complex `read` APIs that manage requests for packages No existing standard exists for package registries. The package registry currently deployed by EthPM would not comply with the standard since it implements only one of the method signatures described in the specification. ## Implementation -A reference implementation of this proposal is in active development at the EthPM organization on Github [here](https://github.com/ethpm/escape-truffle). +A reference implementation of this proposal is in active development at the EthPM organization on GitHub [here](https://github.com/ethpm/escape-truffle). ## Copyright Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). diff --git a/EIPS/eip-1470.md b/EIPS/eip-1470.md index d6f9dffc24f455..8e613bff7100fb 100644 --- a/EIPS/eip-1470.md +++ b/EIPS/eip-1470.md @@ -104,7 +104,7 @@ properties: ## Implementation -The Smart Contract Weakness Classification registry located in this [Github repository](https://github.com/SmartContractSecurity/SWC-registry) uses the SWC scheme proposed in this EIP. A Github Pages rendered version is also available [here](https://smartcontractsecurity.github.io/SWC-registry/). +The Smart Contract Weakness Classification registry located in this [GitHub repository](https://github.com/SmartContractSecurity/SWC-registry) uses the SWC scheme proposed in this EIP. A GitHub Pages rendered version is also available [here](https://smartcontractsecurity.github.io/SWC-registry/). ## Copyright Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). diff --git a/EIPS/eip-1761.md b/EIPS/eip-1761.md index 7d7a51163d293d..d5bec18d120538 100644 --- a/EIPS/eip-1761.md +++ b/EIPS/eip-1761.md @@ -168,8 +168,8 @@ The Scope Metadata JSON Schema was added in order to support human-readable scop - [Enjin Coin](https://enjincoin.io) ([github](https://github.com/enjin)) **Articles & Discussions** -- [Github - Original Discussion Thread](https://github.com/ethereum/EIPs/issues/1761) -- [Github - ERC-1155 Discussion Thread](https://github.com/ethereum/EIPs/issues/1155) +- [GitHub - Original Discussion Thread](https://github.com/ethereum/EIPs/issues/1761) +- [GitHub - ERC-1155 Discussion Thread](https://github.com/ethereum/EIPs/issues/1155) ## Copyright Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). diff --git a/EIPS/eip-2135.md b/EIPS/eip-2135.md index 547a3ead117f5e..181110035d7eae 100644 --- a/EIPS/eip-2135.md +++ b/EIPS/eip-2135.md @@ -64,11 +64,11 @@ This interface is designed to be compatible with ERC-721. A reference implementation accompany with tests of **ERC-721 based ticket** contract is built and you can found it [here](https://github.com/xinbenlv/eip-2135/blob/master/impl/contracts/Ticket721.sol). -See [Github/xinbenlv/eip-2135/impl](https://github.com/xinbenlv/eip-2135/tree/master/impl) +See [GitHub/xinbenlv/eip-2135/impl](https://github.com/xinbenlv/eip-2135/tree/master/impl) ## Test Cases -See [Github/xinbenlv/eip-2135/impl/test](https://github.com/xinbenlv/eip-2135/tree/master/impl/test) +See [GitHub/xinbenlv/eip-2135/impl/test](https://github.com/xinbenlv/eip-2135/tree/master/impl/test) ## Reference diff --git a/EIPS/eip-2255.md b/EIPS/eip-2255.md index 63807737d16121..7789a4ea6a1cf4 100644 --- a/EIPS/eip-2255.md +++ b/EIPS/eip-2255.md @@ -26,7 +26,7 @@ Web3 Wallets are built around the responsibility of mediating the interactions b Today web3 browsers like MetaMask always prompt on a per-action basis. This provides security at the cost of substantial user friction. We believe that a single permissions request can achieve the same level of security with vastly improved UX. -The pattern of permissions requests is common around the web, from login with Facebook, Twitter, Github, and even Apple, making it a very familiar pattern. +The pattern of permissions requests is common around the web, from login with Facebook, Twitter, GitHub, and even Apple, making it a very familiar pattern. ![facebook permissions](https://proxy.duckduckgo.com/iu/?u=https%3A%2F%2Fi.stack.imgur.com%2FG7dRV.png&f=1) diff --git a/EIPS/eip-233.md b/EIPS/eip-233.md index a3378d67c30efb..7dde4bafe65594 100644 --- a/EIPS/eip-233.md +++ b/EIPS/eip-233.md @@ -52,7 +52,7 @@ The Meta EIP representing the hard fork should move in to the `Accepted` state o ## Template -A template for the [Istanbul Hardfork Meta 1679](https://eips.ethereum.org/EIPS/eip-1679) is included below ([source file on Github](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1679.md)): +A template for the [Istanbul Hardfork Meta 1679](https://eips.ethereum.org/EIPS/eip-1679) is included below ([source file on GitHub](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1679.md)): ``` {% raw %} diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index bff8b61ec8f619..1a9b8b1e9a71c9 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -4,5 +4,5 @@ We have a GitHub bot that automatically merges some PRs. It will merge yours imm - The PR edits only existing draft PRs. - The build passes. - - Your Github username or email address is listed in the 'author' header of all affected PRs, inside . + - Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside . - If matching on email address, the email address is the one publicly listed on your GitHub profile. diff --git a/README.md b/README.md index 75b0d57f27463b..9ffb99361a51f6 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Your first PR should be a first draft of the final EIP. It must meet the formatt If your EIP requires images, the image files should be included in a subdirectory of the `assets` folder for that EIP as follows: `assets/eip-N` (where **N** is to be replaced with the EIP number). When linking to an image in the EIP, use relative links such as `../assets/eip-1/image.png`. -Once your first PR is merged, we have a bot that helps out by automatically merging PRs to draft EIPs. For this to work, it has to be able to tell that you own the draft being edited. Make sure that the 'author' line of your EIP contains either your Github username or your email address inside . If you use your email address, that address must be the one publicly shown on [your GitHub profile](https://github.com/settings/profile). +Once your first PR is merged, we have a bot that helps out by automatically merging PRs to draft EIPs. For this to work, it has to be able to tell that you own the draft being edited. Make sure that the 'author' line of your EIP contains either your GitHub username or your email address inside . If you use your email address, that address must be the one publicly shown on [your GitHub profile](https://github.com/settings/profile). When you believe your EIP is mature and ready to progress past the draft phase, you should do one of two things: @@ -48,7 +48,7 @@ eip_validator # Automerger -The EIP repository contains an "auto merge" feature to ease the workload for EIP editors. If a change is made via a PR to a draft EIP, then the authors of the EIP can Github approve the change to have it auto-merged by the [eip-automerger](https://github.com/eip-automerger/automerger) bot. +The EIP repository contains an "auto merge" feature to ease the workload for EIP editors. If a change is made via a PR to a draft EIP, then the authors of the EIP can GitHub approve the change to have it auto-merged by the [eip-automerger](https://github.com/eip-automerger/automerger) bot. # Local development @@ -86,4 +86,4 @@ $ bundle exec jekyll serve 2. Preview your local Jekyll site in your web browser at `http://localhost:4000`. -More information on Jekyll and Github pages [here](https://help.github.com/en/enterprise/2.14/user/articles/setting-up-your-github-pages-site-locally-with-jekyll). +More information on Jekyll and GitHub pages [here](https://help.github.com/en/enterprise/2.14/user/articles/setting-up-your-github-pages-site-locally-with-jekyll). From 15536c18419b9a12cf0e9f3ac398f30fa35b03e2 Mon Sep 17 00:00:00 2001 From: William Entriken Date: Tue, 12 Nov 2019 11:37:10 -0500 Subject: [PATCH 2/2] Delete config --- .bundle/config | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 .bundle/config diff --git a/.bundle/config b/.bundle/config deleted file mode 100644 index 2369228816d467..00000000000000 --- a/.bundle/config +++ /dev/null @@ -1,2 +0,0 @@ ---- -BUNDLE_PATH: "vendor/bundle"