Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding EIP for described data #3224

Merged
merged 29 commits into from
Feb 17, 2021
Merged

Adding EIP for described data #3224

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
882d163
Initial code drop for described data.
ricmoo Jan 24, 2021
385894f
Added summary and a few other points.
ricmoo Jan 24, 2021
751b6fc
Fixed typos.
ricmoo Jan 24, 2021
293d10f
Added result to resposnse, since the contract may populate values the…
ricmoo Jan 24, 2021
593fa6e
Added mime-type to example results.
ricmoo Jan 24, 2021
0b1f2d6
Added link to natspec.
ricmoo Jan 24, 2021
5b63377
Suggested changes to wording/descriptions
Arachnid Jan 25, 2021
84e1ad4
Merge pull request #1 from Arachnid/patch-1
ricmoo Jan 25, 2021
4fc064d
Added more to rationale.
ricmoo Jan 25, 2021
8a5e191
Merged.
ricmoo Jan 25, 2021
47849a1
Updated the version byte in backwards compatibility.
ricmoo Jan 25, 2021
67f7b7c
Better description of the rationale.
ricmoo Jan 25, 2021
f580832
Updated EIP links.
ricmoo Jan 25, 2021
a2b7cf9
Added extra security concerns regarding html.
ricmoo Jan 26, 2021
ca875c7
Added working testcases.
ricmoo Jan 26, 2021
e73f2de
Fixed test case formatting.
ricmoo Jan 26, 2021
ecacae5
Added value to WETH example.
ricmoo Jan 26, 2021
5615360
Fix nested formatting.
ricmoo Jan 26, 2021
b3d7f3c
Added descriptions of encoded data.
ricmoo Jan 26, 2021
fc49da8
Updated test cases with verified contract.
ricmoo Jan 27, 2021
14b50ad
Merge branch 'master' into described-data
ricmoo Jan 27, 2021
0b7c66e
Added EIP number from PR and a discussion-to URL.
ricmoo Jan 27, 2021
7d7cf4c
Fixed codespell typos.
ricmoo Jan 27, 2021
89b56e1
Fixed HtmlLink bad link
ricmoo Jan 27, 2021
47b5943
Updated solidity signature to better match description.
ricmoo Jan 27, 2021
ac94d5d
Added reference to EIP-719 in alternatives.
ricmoo Jan 27, 2021
0707e91
Refer to the describer inderectly.
ricmoo Jan 27, 2021
b92a65e
Fix link to non-repo EIPish-719.
ricmoo Jan 27, 2021
ef04ea7
Updates per reviews by @micahzoltu.
ricmoo Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading