Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request stuck at "Merging can be performed automatically with 0 approving reviews" #334

Closed
henrywfyeung opened this issue Mar 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@henrywfyeung
Copy link

Pull Request

#221

What happened?

I submitted a request on Jan 26. It was a migration from the EIP repository to ERC. This pull request (221) was stuck at the error "Merging can be performed automatically with 0 approving reviews" with no further attention. It seems that the EIP bot should automatically merge the pull request, but it didn't happen. Can someone please advise on how we can proceed from here?

Relevant log output

No response

@henrywfyeung henrywfyeung added the bug Something isn't working label Mar 21, 2024
@iunknow588
Copy link

This seems to be that further discussion and development are needed, the owner or community members need to continue discussing and let the idea ferment for a while.

@abcoathup
Copy link
Contributor

You need to wait for an ERC editor to review.
You could try raising in the EIP editing office hour meeting: ethcatherders/EIPIP#330

@SamWilsn
Copy link
Contributor

Yeah, this isn't a bug. This is just Editors taking ages to review things. Sorry, we'll get to it when we can!

@henrywfyeung
Copy link
Author

No problem at all. Good to know that this is part of the procedure and is not an outcome of a bug. Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants