Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pending deposits and pending partial withdrawals accessors #500

Merged
merged 13 commits into from
Feb 14, 2025

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Feb 11, 2025

There was interest expressed in having access to pending deposits and pending partial withdrawals without needing to download the entire beacon state, and that makes a lot of sense.

I haven't added SSZ support to these at this point, but arguably we probably could...

@rolfyone
Copy link
Contributor Author

that log is wild, but the diff looks right...

@nflaig
Copy link
Member

nflaig commented Feb 11, 2025

I haven't added SSZ support to these at this point, but arguably we probably could...

If all server follow the defined behavior here it's possible to add SSZ support later on as it's backward compatible due to proper content type negotiation between server and client.

But I am definitely in favor of adding SSZ support to new apis

@nflaig nflaig added the Electra label Feb 11, 2025
rolfyone added a commit to rolfyone/teku that referenced this pull request Feb 12, 2025
Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
rolfyone added a commit to rolfyone/teku that referenced this pull request Feb 12, 2025
Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine with adding those apis as they are pretty simple to implement. Left a few comments which are applicable to both endpoints.

rolfyone and others added 2 commits February 13, 2025 05:32
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
rolfyone added a commit to Consensys/teku that referenced this pull request Feb 12, 2025
Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
rolfyone added a commit to Consensys/teku that referenced this pull request Feb 13, 2025
Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone merged commit e446c0e into ethereum:master Feb 14, 2025
3 checks passed
@rolfyone rolfyone deleted the electra-state-reporting branch February 14, 2025 04:14
ensi321 pushed a commit to ChainSafe/lodestar that referenced this pull request Feb 18, 2025
…als (#7472)

**Motivation**

- ethereum/beacon-APIs#500

**Description**

- `GET /eth/v1/beacon/states/{state_id}/pending_deposits` added
- `GET /eth/v1/beacon/states/{state_id}/pending_partial_withdrawals`
added
@github-actions github-actions bot mentioned this pull request Feb 18, 2025
mehdi-aouadi added a commit to Consensys/teku that referenced this pull request Feb 18, 2025
* 25.2.0 Cleanup (#9109)

* update electra fork epoch (#9093)

* update electra epoch version

Signed-off-by: gconnect <agatevureglory@gmail.com>

* Remove MAX_REQUEST_BLOB_SIDECARS

Signed-off-by: gconnect <agatevureglory@gmail.com>

* Add MAX_REQUEST_BLOB_SIDECARS

Signed-off-by: gconnect <agatevureglory@gmail.com>

---------

Signed-off-by: gconnect <agatevureglory@gmail.com>
Co-authored-by: Enrico Del Fante <enrico.delfante@consensys.net>

* Add `SingleAttestation` in pretty print (#9101)

* Add SingleAttestation in pretty print

* Add SingleAttestation in pretty print

* Added GetPendingDeposits (#9110)

Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>

* upgrade besu library (#9116)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

* added getPendingPartialWithdrawals api for electra (#9113)

Partially addresses ethereum/beacon-APIs#500

Attempting to access this data prior to electra will fail with a 400.

Signed-off-by: Paul Harris <paul.harris@consensys.net>

* Improve attestation selection (#9114)

* improve attestation selection

* add test

* improvements

* no need for entrySet

* rename var

---------

Co-authored-by: Paul Harris <paul.harris@consensys.net>

* fix mev gaslimit warning (#9136)

* builder-json-parsing-fix (#9135)

* set Accept header in getPayload (#9137)

---------

Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Co-authored-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Co-authored-by: Glory Agatevure <agatevureglory@gmail.com>
Co-authored-by: Enrico Del Fante <enrico.delfante@consensys.net>
Co-authored-by: Paul Harris <paul.harris@consensys.net>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants