Add LOG_EXPANSION_FACTOR constant #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
approved these changes
Oct 9, 2024
asn-d6
reviewed
Oct 15, 2024
Co-authored-by: George Kadianakis <desnacked@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #512.
Note that in contrast to what is stated in the issue, the code will not work for other constants as it is.
This is because it contains precomputed constants such as
ROOT_OF_UNITYthat are tailored to the expansion factor being two (LOG_EXPANSION_FACTOR = 1). We could have added code to compute the constants on the fly based on the expansion factor, but this would add significant overhead. Therefore, introducing the constant is more a way to improve readability instead of a way to make the code more general.