-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 new invalid test cases #2790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always great to see more test coverage!
i am wondering how the two last tests you wrote differ in terms of SSZ functionality they are touching, they both seem to just add extra data to the end which should yield a deserialization error but not necessarily because the offsets are incorrect (and that is what this part of test gen code suggests it is doing
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Yes you are correct the last 2 tests are not related to invalid offset but are still invalid tests nevertheless, IMHO the more invalid case we have, the better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice updates!
still want to understand your thinking more on structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thanks :)
The 3 test cases;