Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add randomized tests for bellatrix #2821

Merged
merged 1 commit into from
Jan 28, 2022
Merged

add randomized tests for bellatrix #2821

merged 1 commit into from
Jan 28, 2022

Conversation

ralexstokes
Copy link
Member

@ralexstokes ralexstokes commented Jan 28, 2022 •
edited
Loading

fix #2813

this PR:

  1. adds support for generating randomized bellatrix testing
  2. generates randomized bellatrix testing
  3. integrates bellatrix tests into spec test infra

NOTE: this does not exercise "interesting" aspects of bellatrix functionality (bc it only uses "default" constructions) but does put the tests in place to exercise bellatrix code paths

djrtwo
djrtwo approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@djrtwo djrtwo merged commit ccf6f35 into ethereum:dev Jan 28, 2022
@ralexstokes ralexstokes deleted the add-bellatrix-random-tests branch February 10, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing bellatrix random test-gen
2 participants
@ralexstokes @djrtwo