Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP4844: Explicitly mention old gossip validations for block #3091

Merged
merged 2 commits into from
Nov 10, 2022
Merged

EIP4844: Explicitly mention old gossip validations for block #3091

merged 2 commits into from
Nov 10, 2022

Conversation

terencechain
Copy link
Contributor

We should explicitly call out the old gossip block validations in the new beacon_block_and_blobs_sidecar topic.
It currently reads like those old validations are no longer required

@hwwhww hwwhww added the Deneb was called: eip-4844 label Nov 10, 2022
ralexstokes
ralexstokes approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djrtwo djrtwo merged commit 4b573f8 into ethereum:dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terencechain @djrtwo @ralexstokes @hwwhww