Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup explicit fork enumerations in tests #3107

Merged
merged 4 commits into from
Dec 13, 2022
Merged

cleanup explicit fork enumerations in tests #3107

merged 4 commits into from
Dec 13, 2022

Conversation

etan-status
Copy link
Contributor

Fork epoch override test decorators were still referring to SHARDING. Replace the implementation with one that needs less maintenance.

@etan-status
cleanup explicit fork enumerations in tests
b612ec5 
Fork epoch override test decorators were still referring to `SHARDING`.
Replace the implementation with one that needs less maintenance.
@etan-status
Merge branch 'dev' into sf-epochoverrides
c3000ed
@etan-status
Merge branch 'dev' into sf-epochoverrides
8524f54
@etan-status etan-status mentioned this pull request Dec 11, 2022
Merged
hwwhww
hwwhww approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring! This PR makes it easier to maintain 👍👍

I've tested it with gen_sanity test vector generator.

@hwwhww hwwhww merged commit dc17b1e into ethereum:dev Dec 13, 2022
@etan-status etan-status deleted the sf-epochoverrides branch December 13, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etan-status @hwwhww