Fix --preset-list argument and enhance error output #3111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in testgen:
Issue 1
--preset-list
flag was not implemented properly. The parameterpresets
was unused.Fix
if len(presets) != 0 and test_case.preset_name not in presets: continue
to filter the presetsIssue 2
IOError
was not logged properly. It was caught but went tosys.exit()
immediately.Fix
sys.exit()