Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --preset-list argument and enhance error output #3111

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 17, 2022

This PR fixes two issues in testgen:

Issue 1

  • --preset-list flag was not implemented properly. The parameter presets was unused.

Fix

  • Add if len(presets) != 0 and test_case.preset_name not in presets: continue to filter the presets
  • Update README.md

Issue 2

  • IOError was not logged properly. It was caught but went to sys.exit() immediately.

Fix

  • Write exception to log file before sys.exit()

@hwwhww hwwhww merged commit a1d259a into dev Nov 18, 2022
@hwwhww hwwhww deleted the testgen-fix branch November 18, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants