Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor cell recovery code #3781

Merged
merged 29 commits into from
Jun 11, 2024
Merged

chore: Refactor cell recovery code #3781

merged 29 commits into from
Jun 11, 2024

Commits on Jun 7, 2024

  1. multi: 

    - Remove shift_polynomial_coeff
- Remove recover_shifted_data
- Remove recover_original_data
- Move `zero_poly_eval_brp ` under sanity check comment as its only used for sanity checking
    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7930128 View commit details
    Browse the repository at this point in the history

  2. chore: remove sanity check -- this was doing a wasteful `compute_root… 

    …_of_unity` operation
    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    61598ae View commit details
    Browse the repository at this point in the history

  3. chore: add previous sanity check as a unit test

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3382f84 View commit details
    Browse the repository at this point in the history

  4. chore: copy values python was taking a reference, so it passes in our… 

    … regular codepaths but not in isolated test
    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    583adb4 View commit details
    Browse the repository at this point in the history

  5. chore: add coset_fft test

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    01873d5 View commit details
    Browse the repository at this point in the history

  6. Update specs/_features/eip7594/polynomial-commitments-sampling.md 

    Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
    @kevaundray @jtraglia
    kevaundray and jtraglia committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6565122 View commit details
    Browse the repository at this point in the history

  7. Update specs/_features/eip7594/polynomial-commitments-sampling.md 

    Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
    @kevaundray @jtraglia
    kevaundray and jtraglia committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7541930 View commit details
    Browse the repository at this point in the history

  8. chore: linter

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    cd17ff5 View commit details
    Browse the repository at this point in the history

  9. chore: asn (switch to bls_modular_inverse)

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    83c1d20 View commit details
    Browse the repository at this point in the history

  10. chore: (ben) rename func to test_construct_vanishing_polynomial

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f049ea9 View commit details
    Browse the repository at this point in the history

  11. chore: (ben) rename extended_evaluations_coeffs to `extended_evalua… 

    …tion_times_zero_coeffs`
    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    44031e0 View commit details
    Browse the repository at this point in the history

  12. chore: compute roots_of_unity_extended in recover_data method

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    af3520a View commit details
    Browse the repository at this point in the history

  13. chore: add more comments explaining whats happening in recover_data

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    daa7497 View commit details
    Browse the repository at this point in the history

  14. chore: compute_zero_poly_coeff in recover_data

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    6144e3d View commit details
    Browse the repository at this point in the history

  15. chore: make lint

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1e6d91f View commit details
    Browse the repository at this point in the history

  16. chore: add doc comment to coset_fft_field

    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    1593ede View commit details
    Browse the repository at this point in the history

  17. chore: (ben) add code to generate the vanishing polynomial when all c… 

    …ells are missing
    @kevaundray
    kevaundray committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b0be78a View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. chore: remove handling of edge case when constructing a vanishing pol… 

    …ynomial
    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8b70ec6 View commit details
    Browse the repository at this point in the history

  2. chore: rename H(x) to Q_3(x)

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b9ecf3d View commit details
    Browse the repository at this point in the history

  3. chore: remove trailing whitespace

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4da3dcd View commit details
    Browse the repository at this point in the history

  4. chore: add whitespace between comments

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    425d066 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into kw/recover_all_cells_ref

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    232510c View commit details
    Browse the repository at this point in the history

  6. chore: (asn) add assert that num missing cells is not 0

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    33e3d72 View commit details
    Browse the repository at this point in the history

  7. chore: (justin) address comments

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    dfcd7c3 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dev' into kw/recover_all_cells_ref

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    75dc975 View commit details
    Browse the repository at this point in the history

  9. chore: merge resolution

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a6071e0 View commit details
    Browse the repository at this point in the history

  10. chore: fixup remaining IDs -> indices

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9523acf View commit details
    Browse the repository at this point in the history

  11. chore: use indice nomenclature in tests

    @kevaundray
    kevaundray committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4b9d91e View commit details
    Browse the repository at this point in the history

  12. Merge branch 'dev' into kw/recover_all_cells_ref

    @jtraglia
    jtraglia authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c43b167 View commit details
    Browse the repository at this point in the history