Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unmodified functions in Electra LC #3987

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Oct 18, 2024

Since LightClientHeader is not modified in Electra, it is safe to remove block_to_light_client_header and is_valid_light_client_header from Electra spec.

One debatable point is whether we want to keep full-node.md for Electra as there is no change to it.

@jtraglia
Copy link
Member

Seems reasonable to me. We should remove full-node.md if there are no changes. Don't forget to remove the full node link from list of spec changes on the README, here:

| 5 | **Electra** | TBD | <ul><li>Core</li><ul><li>[Beacon Chain changes](specs/electra/beacon-chain.md)</li><li>[Electra fork](specs/electra/fork.md)</li></ul><li>Additions</li><ul><li>[Light client sync protocol changes](specs/electra/light-client/sync-protocol.md) ([fork](specs/electra/light-client/fork.md), [full node](specs/electra/light-client/full-node.md), [networking](specs/electra/light-client/p2p-interface.md))</li><li>[Honest validator guide changes](specs/electra/validator.md)</li><li>[P2P networking](specs/electra/p2p-interface.md)</li></ul></ul> |

@jtraglia jtraglia merged commit 60cd223 into ethereum:dev Oct 20, 2024
25 checks passed
Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The full-node.md is no longer necessary as execution_requests were moved away from the execution_payload so no longer affect LightClientHeader.

etan-status added a commit to etan-status/consensus-specs that referenced this pull request Nov 22, 2024
Followup from ethereum#3987 to remove references to the deleted document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants