Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert new quizzes #10873

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Revert new quizzes #10873

merged 1 commit into from
Aug 7, 2023

Conversation

pettinarip
Copy link
Member

Due to recent issues detected in the Quizzes hub page, we decided to revert the additions of the new quizzes until we refactor the code to avoid any crashes.

Description

Reverts the following PRs: #10475, #10476, and #10477.

Related Issue

#10828

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 5, 2023

✅ ethereum-org-website-dev deploy preview ready

@corwintines
Copy link
Member

Is there a way to remove the links to quizzes on /quizzes/ but keep these for the actual pages themselves?

@pettinarip
Copy link
Member Author

Is there a way to remove the links to quizzes on /quizzes/ but keep these for the actual pages themselves?

Oh good idea @corwintines! let me try doing that instead.

@wackerow
Copy link
Member

wackerow commented Aug 7, 2023

Agree it would be nice to only remove from the quiz hub if possible, but also don't want this to sit too long since it's currently breaking the quiz hub.

@pettinarip
Copy link
Member Author

I pushed the revert again since it was missing a few things, now it should work as expected.

@corwintines @wackerow I tried to keep the individual quizzes on the specific pages but I don't think it is possible because the QuizWidget and the Hub are storing the results in localstorage, so it is messing with the final stats displayed in the hub.

@wackerow
Copy link
Member

wackerow commented Aug 7, 2023

Okay... bit of a bummer, but hopefully we can get this figured out eventually so we can add more quizzes. No question that this quiz hub needs to be flexible to account for new quizzes and questions in the future.

@wackerow
Copy link
Member

wackerow commented Aug 7, 2023

Noticing too while reviewing these, and commented similarly on #10862 (comment) that the "Completed" count only increments if the user gets 100%, and same with the green tick.

image

^ After completing the "Ethereum security and scam prevention" quiz with one wrong answer.

I think we should reconsider how to display this... if we want to have an exclusive counter for perfect quizzes, I would rename this to something other than "Completed" although I don't think holding people to perfect scores is the best way to go. We currently use PASSING_QUIZ_SCORE = 65, so perhaps we update this term and include any quiz that is above that threshold instead. Also we may want to have some additional indicators aside from the green tick to indicate that the quiz has been 1- been attempted, 2- passed, 3- completed perfect.

wackerow
wackerow previously approved these changes Aug 7, 2023
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make sure we come back to this 🙏
Thanks for addressing this @pettinarip!

@pettinarip pettinarip changed the title Revert new quizzes [Hotfix] revert new quizzes Aug 7, 2023
@pettinarip pettinarip changed the base branch from dev to master August 7, 2023 11:13
@pettinarip pettinarip dismissed wackerow’s stale review August 7, 2023 11:13

The base branch was changed.

@pettinarip pettinarip changed the base branch from master to dev August 7, 2023 11:14
@pettinarip pettinarip changed the title [Hotfix] revert new quizzes Revert new quizzes Aug 7, 2023
@wackerow wackerow merged commit 7bfb628 into dev Aug 7, 2023
@wackerow wackerow deleted the revert-quizzes branch August 7, 2023 12:09
@pettinarip
Copy link
Member Author

Noticing too while reviewing these, and commented similarly on #10862 (comment) that the "Completed" count only increments if the user gets 100%, and same with the green tick.

image ^ After completing the "Ethereum security and scam prevention" quiz with one wrong answer.

I think we should reconsider how to display this... if we want to have an exclusive counter for perfect quizzes, I would rename this to something other than "Completed" although I don't think holding people to perfect scores is the best way to go. We currently use PASSING_QUIZ_SCORE = 65, so perhaps we update this term and include any quiz that is above that threshold instead. Also we may want to have some additional indicators aside from the green tick to indicate that the quiz has been 1- been attempted, 2- passed, 3- completed perfect.

cc ^ fyi @konopkja

@konopkja
Copy link
Contributor

konopkja commented Aug 8, 2023

Noticing too while reviewing these, and commented similarly on #10862 (comment) that the "Completed" count only increments if the user gets 100%, and same with the green tick.
image
^ After completing the "Ethereum security and scam prevention" quiz with one wrong answer.
I think we should reconsider how to display this... if we want to have an exclusive counter for perfect quizzes, I would rename this to something other than "Completed" although I don't think holding people to perfect scores is the best way to go. We currently use PASSING_QUIZ_SCORE = 65, so perhaps we update this term and include any quiz that is above that threshold instead. Also we may want to have some additional indicators aside from the green tick to indicate that the quiz has been 1- been attempted, 2- passed, 3- completed perfect.

cc ^ fyi @konopkja

good catch, the status "success" on final page should correspond to "completed" in the table and for the v2 we could think of enhancing this experience

This was referenced Aug 9, 2023
@minimalsm minimalsm mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants