-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert new quizzes #10873
Revert new quizzes #10873
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
Is there a way to remove the links to quizzes on /quizzes/ but keep these for the actual pages themselves? |
Oh good idea @corwintines! let me try doing that instead. |
Agree it would be nice to only remove from the quiz hub if possible, but also don't want this to sit too long since it's currently breaking the quiz hub. |
ed72532
to
7937f8f
Compare
I pushed the revert again since it was missing a few things, now it should work as expected. @corwintines @wackerow I tried to keep the individual quizzes on the specific pages but I don't think it is possible because the QuizWidget and the Hub are storing the results in localstorage, so it is messing with the final stats displayed in the hub. |
Okay... bit of a bummer, but hopefully we can get this figured out eventually so we can add more quizzes. No question that this quiz hub needs to be flexible to account for new quizzes and questions in the future. |
Noticing too while reviewing these, and commented similarly on #10862 (comment) that the "Completed" count only increments if the user gets 100%, and same with the green tick. ^ After completing the "Ethereum security and scam prevention" quiz with one wrong answer. I think we should reconsider how to display this... if we want to have an exclusive counter for perfect quizzes, I would rename this to something other than "Completed" although I don't think holding people to perfect scores is the best way to go. We currently use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just make sure we come back to this 🙏
Thanks for addressing this @pettinarip!
cc ^ fyi @konopkja |
good catch, the status "success" on final page should correspond to "completed" in the table and for the v2 we could think of enhancing this experience |
Due to recent issues detected in the Quizzes hub page, we decided to revert the additions of the new quizzes until we refactor the code to avoid any crashes.
Description
Reverts the following PRs: #10475, #10476, and #10477.
Related Issue
#10828