This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Feature/eip 1052 #1162
Merged
Feature/eip 1052 #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
suggested changes
Aug 21, 2018
| @@ -147,7 +147,7 @@ public synchronized void saveCode(byte[] addr, byte[] code) { | |||
| @Override | |||
| public byte[] getCodeHash(byte[] addr) { | |||
| AccountState accountState = getAccountState(addr); | |||
| return accountState != null ? accountState.getCodeHash() : HashUtil.EMPTY_DATA_HASH; | |||
| return accountState != null ? accountState.getCodeHash() : null; | |||
There was a problem hiding this comment.
Are you sure that this change won't break anything else than getCode?
There was a problem hiding this comment.
@mkalinin checked it with extra attention, it shouldn't break anything for us
| PrecompiledContracts.getContractForAddress(address, blockchainConfig); | ||
|
|
||
| byte[] codeHash; | ||
| // The EXTCODEHASH of an precompiled contract is either c5d246... or 0 |
There was a problem hiding this comment.
I think it means that if precompile acc is non-existent the hash is 0 otherwise the hash is an empty data hash.
There was a problem hiding this comment.
Hence, precompile contract doesn't need a special case to be processed
…re existant in repo
mkalinin
approved these changes
Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge,
GitHubBlockStateTesttests are not passed.