Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/utils, eth/downloader: minor snap nitpicks #22122

Merged
merged 1 commit into from
Jan 7, 2021
Merged

cmd/utils, eth/downloader: minor snap nitpicks #22122

merged 1 commit into from
Jan 7, 2021

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Jan 6, 2021

No description provided.

@karalabe karalabe added this to the 1.10.0 milestone Jan 6, 2021
holiman
holiman approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe
Copy link
Member Author

karalabe commented Jan 7, 2021

@DGKSK8LIFE Please stop spamming our repository. If you have a note to add, those are welcome, but it makes no sense to keep adding review approvals to PRs.

@karalabe karalabe merged commit 8bd8e1b into ethereum:master Jan 7, 2021
@quorumbot quorumbot mentioned this pull request Sep 3, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGKSK8LIFE DGKSK8LIFE DGKSK8LIFE approved these changes

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @holiman @DGKSK8LIFE