graphql: fix spurious travis failure #22166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jan 13, 2021
graphql/graphql_test.go
Outdated
| WSHost: "127.0.0.1", | ||
| WSPort: 9393, | ||
| WSPort: port, |
holiman
commented
Jan 13, 2021
graphql/graphql_test.go
Outdated
| }) | ||
| if err != nil { | ||
| t.Fatalf("could not create node: %v", err) | ||
| } | ||
| if !gqlEnabled { | ||
| return stack | ||
| } | ||
| createGQLService(t, stack, fmt.Sprintf("127.0.0.1:%d", port)) | ||
| createGQLService(t, stack, node.DefaultHTTPEndpoint()) |
There was a problem hiding this comment.
Bleh, I'll fix this
holiman
force-pushed
the
graphql_fix_2
branch
from
5c645ae
to
a0cf3cb
Compare
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
The tests sometimes failed with certain go versions because the behavior of http.Server.Shutdown changed over time. A bug that was fixed in Go 1.15 could cause active connections on unrelated servers to close unexpectedly. This is fixed by avoiding use of the same port number in all tests.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go
1.14, the graphql tests runs really fast:But sometimes they fail:
In go
1.15, they run slow. ButBut they don't spuriously fail!
So the delay seems to be working. What is the delay? The delay is improved in this commit: golang/go@f0c9ae5 , and digging into the back-story a bit, it can be surmised that there's a race between closing connecttions, and that there may be active connections that get bit by it. It seems that
1.14suffers from this. Maybe a straggling 'close' or 'reset' is still on the network when the next connection is made.Whatever the reason, it seems that a working fix is to not use the same port every time, but randomize it a bit. With this PR, I no longer trigger the error on go
1.14.