cmd/utils: set name to chaindata for all the opened db #31352
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth/ethconfig/config.go
Outdated
Member
There was a problem hiding this comment.
I’d prefer to place the constant database name and metric namespace in their respective locations. Defining them here feels a bit out of place.
cmd/utils/flags.go
Outdated
Member
There was a problem hiding this comment.
I think you can just put the constant metric namespace here. No need to use a global constant var
Contributor
Author
There was a problem hiding this comment.
how about we just use the constant name here, @MariusVanDerWijden WDYT
Contributor
Author
There was a problem hiding this comment.
I prefer to the fist simple one, keep it simple
rjl493456442
approved these changes
Mar 18, 2025
rjl493456442
changed the title
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
When I'm running `geth import --metrics`, the metrics is different to normal `geth --metrics`, so the grafana dashboard needs to be updated, eg: `eth_db_chaindata_disk_read` vs `disk_read`. So I think we should always set the name to `eth/db/chaindata` for more convenient. --------- Signed-off-by: jsvisa <delweng@gmail.com>
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
When I'm running `geth import --metrics`, the metrics is different to normal `geth --metrics`, so the grafana dashboard needs to be updated, eg: `eth_db_chaindata_disk_read` vs `disk_read`. So I think we should always set the name to `eth/db/chaindata` for more convenient. --------- Signed-off-by: jsvisa <delweng@gmail.com>
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
When I'm running `geth import --metrics`, the metrics is different to normal `geth --metrics`, so the grafana dashboard needs to be updated, eg: `eth_db_chaindata_disk_read` vs `disk_read`. So I think we should always set the name to `eth/db/chaindata` for more convenient. --------- Signed-off-by: jsvisa <delweng@gmail.com>
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
When I'm running `geth import --metrics`, the metrics is different to normal `geth --metrics`, so the grafana dashboard needs to be updated, eg: `eth_db_chaindata_disk_read` vs `disk_read`. So I think we should always set the name to `eth/db/chaindata` for more convenient. --------- Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm running
geth import --metrics, the metrics is different to normalgeth --metrics, so the grafana dashboard needs to be updated, eg:eth_db_chaindata_disk_readvsdisk_read.So I think we should always set the name to
eth/db/chaindatafor more convenient.