Skip to content

Conversation

@alarso16
Copy link
Contributor

@alarso16 alarso16 commented Oct 28, 2025

This part of the WaitDeployedCornerCases test has many issues.

  • The real error that should be checked is context.Canceled, which can easily be used.
  • The boolean for errors.Is is incorrect, allowing the test to still pass even though the incorrect error is returned.
  • The errors are in the wrong order for errors.Is
  • err == nil doesn't change the output of this test, since want isn't nil.

@alarso16 alarso16 marked this pull request as ready for review October 28, 2025 16:32
@rjl493456442 rjl493456442 added this to the 1.16.6 milestone Oct 29, 2025
@rjl493456442 rjl493456442 changed the title test: Fix incorrect error check accounts/abi/bind/v2: fix error assertion in test Oct 29, 2025
@rjl493456442 rjl493456442 merged commit ae37b49 into ethereum:master Oct 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants