Use simplifying constructor for PEq #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to always normalize Prop equalities such that concrete values appear on the left-hand-side. This follows the example of the helper functions for expressions, that also immediately simplify if they get concrete arguments, and normalize arguments for commutative operations.
blishko
commented
Aug 27, 2024
| @@ -432,6 +432,14 @@ data Prop where | |||
| PBool :: Bool -> Prop | |||
| deriving instance (Show Prop) | |||
|
|
|||
| mkPEq :: (Typeable a) => Expr a -> Expr a -> Prop | |||
There was a problem hiding this comment.
Not sure what would be the best name.
I originally had peq, to follow the example of the helper functions for Expr, but I don't like that very much. I think that mkPEq better conveys what the function is doing. We could also use full makePEq.
@msooseth, opinions?
There was a problem hiding this comment.
This sounds like a good name to me.
msooseth
requested changes
Aug 27, 2024
| @@ -432,6 +432,14 @@ data Prop where | |||
| PBool :: Bool -> Prop | |||
| deriving instance (Show Prop) | |||
|
|
|||
| mkPEq :: (Typeable a) => Expr a -> Expr a -> Prop | |||
There was a problem hiding this comment.
This sounds like a good name to me.
msooseth
approved these changes
Aug 27, 2024
|
OK, merging. Let's make sure to add a CHANGELOG entry next time, though! Also, we should add a fuzz test for this as well as the Expr LHS/RHS ;) |
|
Thanks so much! Really good stuff! We should have done this ages ago! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to always normalize Prop equalities such that concrete values appear on the left-hand-side.
This follows the example of the helper functions for expressions, that also immediately simplify if they get concrete arguments, and normalize arguments for commutative operations.
Checklist