-
Notifications
You must be signed in to change notification settings - Fork 519
simulators/eth2/withdrawals: add builder tests #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acb8e1e to
ddc6697
Compare
Member
Author
|
@fjl let me know if it's ok to include client's changes in this same PR or I can split it up in a PR for each client (adds Builder API parameters to all consensus clients). |
ddc6697 to
5782437
Compare
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
allow setting vc_* properties in participants_matrix.cl:
```
participants_matrix:
el:
- el_type: nethermind
el_image: nethermindeth/nethermind:pectra
- el_type: geth
el_image: ethpandaops/geth:lightclient-prague-devnet-1
cl:
- cl_type: teku
cl_image: ethpandaops/teku:master
- cl_type: nimbus
cl_image: ethpandaops/nimbus-eth2:unstable
- cl_type: lodestar
cl_image: ethpandaops/lodestar:electra-fork
vc_max_mem: 1024
- cl_type: grandine
cl_image: ethpandaops/grandine:electra
```
in the example above, lodestar vc needs more than 500M memory for key
import, so I'd like to override the vc_max_mem accordingly.
This is theoretically allowed by the logic, but the new sanity check
prevents it.
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](ethpandaops/ethereum-package@4.1.0...4.2.0) (2024-08-19) ### Features * add customizable configuraiton for prometheus retention ([ethereum#745](ethpandaops/ethereum-package#745)) ([6c02dfe](ethpandaops/ethereum-package@6c02dfe)) * add genesis_gaslimit param configuration ([ethereum#726](ethpandaops/ethereum-package#726)) ([a4ba9a6](ethpandaops/ethereum-package@a4ba9a6)) * Add Lighthouse PeerDAS Dashboard ([ethereum#736](ethpandaops/ethereum-package#736)) ([ffbfde2](ethpandaops/ethereum-package@ffbfde2)) * add peerdas-electra-support ([ethereum#740](ethpandaops/ethereum-package#740)) ([663e7e6](ethpandaops/ethereum-package@663e7e6)) * add profiling for prysm ([ethereum#722](ethpandaops/ethereum-package#722)) ([7dc6660](ethpandaops/ethereum-package@7dc6660)) * add sanity check ([ethereum#710](ethpandaops/ethereum-package#710)) ([b824cac](ethpandaops/ethereum-package@b824cac)) * enable dora pprof ([ethereum#743](ethpandaops/ethereum-package#743)) ([2b7be9a](ethpandaops/ethereum-package@2b7be9a)) * generate keys if not default key is used ([ethereum#707](ethpandaops/ethereum-package#707)) ([2d1cab5](ethpandaops/ethereum-package@2d1cab5)) * lodestar persists invalid ssz objects by default ([ethereum#730](ethpandaops/ethereum-package#730)) ([5a45991](ethpandaops/ethereum-package@5a45991)) * update egg config parameters ([ethereum#737](ethpandaops/ethereum-package#737)) ([78c2bc7](ethpandaops/ethereum-package@78c2bc7)) ### Bug Fixes * add debug ns to nethermind ([ethereum#732](ethpandaops/ethereum-package#732)) ([372bb52](ethpandaops/ethereum-package@372bb52)) * allow vc properties in participants_matrix.cl ([ethereum#715](ethpandaops/ethereum-package#715)) ([c8b9b19](ethpandaops/ethereum-package@c8b9b19)) * besu devnet schedule ([ethereum#734](ethpandaops/ethereum-package#734)) ([28b67cd](ethpandaops/ethereum-package@28b67cd)) * blobscan redis dependency ([ethereum#712](ethpandaops/ethereum-package#712)) ([0ed1c9c](ethpandaops/ethereum-package@0ed1c9c)) * change churn limit default for pectra tests ([ethereum#747](ethpandaops/ethereum-package#747)) ([8109054](ethpandaops/ethereum-package@8109054)) * correctly apply extra params if builder is enabled ([ethereum#725](ethpandaops/ethereum-package#725)) ([a94caf0](ethpandaops/ethereum-package@a94caf0)) * disable all assertoor tests by default ([ethereum#738](ethpandaops/ethereum-package#738)) ([2961f96](ethpandaops/ethereum-package@2961f96)) * lodestar vc faster startup ([ethereum#721](ethpandaops/ethereum-package#721)) ([225e3d8](ethpandaops/ethereum-package@225e3d8)) * readme eof ([ethereum#739](ethpandaops/ethereum-package#739)) ([7f94f6e](ethpandaops/ethereum-package@7f94f6e)) * remove custom peerdas images for dora & assertoor ([ethereum#741](ethpandaops/ethereum-package#741)) ([a19398d](ethpandaops/ethereum-package@a19398d)) * remove subscribe all subnet nimbus ([ethereum#719](ethpandaops/ethereum-package#719)) ([ef92f8f](ethpandaops/ethereum-package@ef92f8f)) * remove subscribe-all-subnets from default prysm config ([ethereum#717](ethpandaops/ethereum-package#717)) ([6348c0b](ethpandaops/ethereum-package@6348c0b)) * remove subscribe-all-subnets lighthouse/lodestar/teku ([ethereum#720](ethpandaops/ethereum-package#720)) ([cdb20e1](ethpandaops/ethereum-package@cdb20e1)) * update snapshots URL ([ethereum#731](ethpandaops/ethereum-package#731)) ([f9269ad](ethpandaops/ethereum-package@f9269ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Included
eth2/commonlibrary that is able to relay payload requests to a local Execution client to simulate a working builderClients passing tests:
Lodestar test is currently failing because it stops requesting headers from the builder at the Capella fork.Fixed by ChainSafe/lodestar#5179