From dd29cc270ec09ed972cef939296d70944475eeac Mon Sep 17 00:00:00 2001 From: Luca Zeug Date: Tue, 20 Dec 2016 15:12:32 +0100 Subject: [PATCH 1/4] [ESLint] update 'scripts' --- .eslintrc.yml | 5 ++++- scripts/build-dist.js | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index b0d68de7d..5e43befab 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -7,7 +7,6 @@ settings: import/core-modules: ## don't lint for these missing packages in package.json - electron ## 'electron' is only needed as devDependency / global installation - rules: # "off" or 0 - turn the rule off # "warn" or 1 - turn the rule on as a warning (doesn’t affect exit code) @@ -23,6 +22,10 @@ rules: comma-dangle: - error - only-multiline + import/no-extraneous-dependencies: + - error + - devDependencies: + - "**/*.test.js" globals: # don't warn about missing declarations i18n: true diff --git a/scripts/build-dist.js b/scripts/build-dist.js index 15a4f0620..0c69f717d 100755 --- a/scripts/build-dist.js +++ b/scripts/build-dist.js @@ -1,4 +1,6 @@ #!/usr/bin/env node +/* eslint-disable import/no-extraneous-dependencies */ + const builder = require('electron-builder'); const shell = require('shelljs'); const Q = require('bluebird'); From 619afc4121c17ffb7991468115ed981a1e991666 Mon Sep 17 00:00:00 2001 From: Luca Zeug Date: Wed, 21 Dec 2016 13:33:49 +0100 Subject: [PATCH 2/4] add comments to .eslintrc --- .eslintrc.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 5e43befab..11b092857 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -21,10 +21,10 @@ rules: no-underscore-dangle: off comma-dangle: - error - - only-multiline - import/no-extraneous-dependencies: + - only-multiline ## no comma after last item if one line, though allow comma if multiline + import/no-extraneous-dependencies: ## checks for missing modules in packages.json - error - - devDependencies: + - devDependencies: ## declares files belonging to devDependencies - "**/*.test.js" globals: # don't warn about missing declarations From 8467dcb9baf69a32dbb0694f698896594f503383 Mon Sep 17 00:00:00 2001 From: Luca Zeug Date: Thu, 22 Dec 2016 15:39:31 +0100 Subject: [PATCH 3/4] update paths --- .eslintrc.yml | 1 + scripts/build-dist.js | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 11b092857..3b6dc4544 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -25,6 +25,7 @@ rules: import/no-extraneous-dependencies: ## checks for missing modules in packages.json - error - devDependencies: ## declares files belonging to devDependencies + - "**/scripts/*.js" - "**/*.test.js" globals: # don't warn about missing declarations diff --git a/scripts/build-dist.js b/scripts/build-dist.js index 0c69f717d..15a4f0620 100755 --- a/scripts/build-dist.js +++ b/scripts/build-dist.js @@ -1,6 +1,4 @@ #!/usr/bin/env node -/* eslint-disable import/no-extraneous-dependencies */ - const builder = require('electron-builder'); const shell = require('shelljs'); const Q = require('bluebird'); From b2e660901dcae5ea214d35ec444a870bbcda82e4 Mon Sep 17 00:00:00 2001 From: Luca Zeug Date: Thu, 22 Dec 2016 15:42:09 +0100 Subject: [PATCH 4/4] update comments --- .eslintrc.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 3b6dc4544..a3d15d411 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -22,9 +22,9 @@ rules: comma-dangle: - error - only-multiline ## no comma after last item if one line, though allow comma if multiline - import/no-extraneous-dependencies: ## checks for missing modules in packages.json + import/no-extraneous-dependencies: ## checks if required modules are missing in packages.json - error - - devDependencies: ## declares files belonging to devDependencies + - devDependencies: ## declares files, whose imports belong to devDependencies - "**/scripts/*.js" - "**/*.test.js"