-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds reserved keywords virtual
.
#7382
Conversation
This should target the |
487faa0
to
ac33345
Compare
I don't think we should reserve copy at the current time. |
Okay, so only |
ac33345
to
b5a92c6
Compare
b5a92c6
to
59955be
Compare
copy
and virtual
.virtual
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine with merging this - although we will actually implement virtual for 0.6.0 anyways (at least I hope we will :-)), so we might as well skip this and just add it as real keyword once we do that.
I'm just walking through some tickets in the ToDo lane. I know that @Marenz is working on |
Closes #6040
Simply adds those keywords to the reserved-keywords list, adjusting documentation and ChangeLog to it.
There is a
/docs/050-breaking-changes.rst
but none for 0.6.0 yet, at lest I didn't find any changelog in the docs/ folder for 0.6.0 just yet - maybe someone can give me a hint in case I overlooked that, so I can adapt that.