Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reserved keywords virtual. #7382

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

christianparpart
Copy link
Member

Closes #6040

Simply adds those keywords to the reserved-keywords list, adjusting documentation and ChangeLog to it.

There is a /docs/050-breaking-changes.rst but none for 0.6.0 yet, at lest I didn't find any changelog in the docs/ folder for 0.6.0 just yet - maybe someone can give me a hint in case I overlooked that, so I can adapt that.

@ekpyron
Copy link
Member

ekpyron commented Sep 9, 2019

This should target the develop_060 branch. Did we actually agree on copy? I think the naming isn't even clear yet between copy, copyof and clone and this is probably postponed until 0.7 anyways, so do we need to reserve it now?

@chriseth
Copy link
Contributor

chriseth commented Sep 9, 2019

I don't think we should reserve copy at the current time.

@christianparpart
Copy link
Member Author

Okay, so only virtual then.

@ekpyron ekpyron changed the base branch from develop to develop_060 September 9, 2019 11:37
@christianparpart christianparpart changed the title Adds reserved keywords copy and virtual. Adds reserved keywords virtual. Sep 9, 2019
Copy link
Member

@ekpyron ekpyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with merging this - although we will actually implement virtual for 0.6.0 anyways (at least I hope we will :-)), so we might as well skip this and just add it as real keyword once we do that.

@christianparpart
Copy link
Member Author

I'd be fine with merging this - although we will actually implement virtual for 0.6.0 anyways (at least I hope we will :-)), so we might as well skip this and just add it as real keyword once we do that.

I'm just walking through some tickets in the ToDo lane. I know that @Marenz is working on override, and I think that this doesn't interfere. In case we want to implement some virtual-semantics (given enough time before [special-date-here] 0.6.0 release, then we can still do so :-)

@chriseth chriseth merged commit b6b2a3b into develop_060 Sep 9, 2019
@chriseth chriseth deleted the 060-reserved-keywords branch September 9, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants