Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Petersburg tests after update to tests v7.0.0-beta.1 #608

Closed
s1na opened this issue Nov 5, 2019 · 0 comments · Fixed by #607
Closed

Failing Petersburg tests after update to tests v7.0.0-beta.1 #608

s1na opened this issue Nov 5, 2019 · 0 comments · Fixed by #607

Comments

@s1na
Copy link
Contributor

s1na commented Nov 5, 2019

After updating tests to v7.0.0-beta.1 in #607, these tests are failing for constantinople and petersburg:

  Failed Tests: There were 10 failures

    file: RevertPrecompiledTouch test: RevertPrecompiledTouch

      ✖ the state roots should match
      ✖ the state roots should match


    file: RevertPrecompiledTouchExactOOG test: RevertPrecompiledTouchExactOOG

      ✖ the state roots should match
      ✖ the state roots should match
      ✖ the state roots should match
      ✖ the state roots should match
      ✖ the state roots should match
      ✖ the state roots should match


    file: RevertPrecompiledTouch_storage test: RevertPrecompiledTouch_storage

      ✖ the state roots should match
      ✖ the state roots should match

These relate to touching precompiles and reverting them which doesn't happen on mainnet or any running chain so it's not a severe problem. I found this exhaustive and great thread in ethereum/py-evm#1857 and a PR fixing the issue (among other things) in ethereum/py-evm#1858.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants