-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create less instances of bn.js #256
Conversation
Fixed this too. |
@holgerd77 this is ready too |
5385927
to
8073872
Compare
Rebased this so that this can be merged after review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
runState.gasLeft.iadd(new BN(fees.callStipend.v)) | ||
options.gasLimit.iadd(new BN(fees.callStipend.v)) | ||
runState.gasLeft.iaddn(fees.callStipend.v) | ||
options.gasLimit.iaddn(fees.callStipend.v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
||
if (reward.lt(new BN(0))) { | ||
if (reward.ltn(0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good as well.
No description provided.