Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create less instances of bn.js #256

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Create less instances of bn.js #256

merged 1 commit into from
Feb 1, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jan 30, 2018

No description provided.

@axic axic requested a review from holgerd77 January 30, 2018 12:51
@axic axic mentioned this pull request Feb 1, 2018
@axic
Copy link
Member Author

axic commented Feb 1, 2018

Fixed this too.

@axic
Copy link
Member Author

axic commented Feb 1, 2018

@holgerd77 this is ready too

@holgerd77
Copy link
Member

Rebased this so that this can be merged after review.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

runState.gasLeft.iadd(new BN(fees.callStipend.v))
options.gasLimit.iadd(new BN(fees.callStipend.v))
runState.gasLeft.iaddn(fees.callStipend.v)
options.gasLimit.iaddn(fees.callStipend.v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


if (reward.lt(new BN(0))) {
if (reward.ltn(0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good as well.

@axic axic merged commit b56bb7d into master Feb 1, 2018
@axic axic deleted the less-new-bn branch February 1, 2018 13:28
@axic axic removed the in progress label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants