Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Tests for runJit and fakeBlockchain #331

Merged
merged 3 commits into from
Aug 13, 2018
Merged

API Tests for runJit and fakeBlockchain #331

merged 3 commits into from
Aug 13, 2018

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Aug 8, 2018

This PR contains tests for runJit and fakeBlockchain. I bundled them together since the changeset was rather small.

holgerd77
holgerd77 reviewed Aug 9, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, also tested locally. Will approve once this is rebased. Thanks for the work so far! 👍

s1na added 2 commits August 9, 2018 15:18
@s1na
Add tests for runJit
da631c3 
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
@s1na
Add tests for fakeBlockChain
d7a6bf0 
Signed-off-by: Sina Mahmoodi <itz.s1na@gmail.com>
holgerd77
holgerd77 approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a merge commit now to update to the latest changes, will approve and merge

@holgerd77 holgerd77 merged commit 86dfbc5 into ethereumjs:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1na @holgerd77 @evertonfraga