From c2a6a012bf1d8fcd5805e45754cebdfe211c6933 Mon Sep 17 00:00:00 2001 From: Richard Moore Date: Thu, 24 Feb 2022 03:51:53 -0500 Subject: [PATCH] Fix contracts when name resolution fails without any checks (#2737). --- packages/contracts/src.ts/index.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/contracts/src.ts/index.ts b/packages/contracts/src.ts/index.ts index a3cb9a927d..2f96bae14a 100644 --- a/packages/contracts/src.ts/index.ts +++ b/packages/contracts/src.ts/index.ts @@ -720,6 +720,9 @@ export class BaseContract { } } + // Swallow bad ENS names to prevent Unhandled Exceptions + this.resolvedAddress.catch((e) => { }); + const uniqueNames: { [ name: string ]: Array } = { }; const uniqueSignatures: { [ signature: string ]: boolean } = { }; Object.keys(this.interface.functions).forEach((signature) => { @@ -879,6 +882,7 @@ export class BaseContract { if (this.deployTransaction) { defineReadOnly(contract, "deployTransaction", this.deployTransaction); } + return contract; }