Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookupAddress(node) has non-standard behavior due to not lowercasing address #269

Closed
marekkirejczyk opened this issue Sep 6, 2018 · 3 comments
Labels
discussion Questions, feedback and general information.

Comments

@marekkirejczyk
Copy link

marekkirejczyk commented Sep 6, 2018

As specified here reverse ENS address should be lowered case, while lookupAddress method is using utils.getAddress, which will return address mixed case.

I suspect in file provider.js line 968 instead of

address = utils.getAddress(address);

should be

address = utils.getAddress(address).toLowerCase();
@ricmoo
Copy link
Member

ricmoo commented Sep 6, 2018

Are you having an issue with this not working? Can you provide an example to reproduce the issue?

The line immediately afterwards calls namehash, which performs toLowerCase() on the provided name. The checksum address is required later in the function when comparing to the result from the ENS contracts.

Thanks! :)

@ricmoo ricmoo added the discussion Questions, feedback and general information. label Sep 6, 2018
@ricmoo
Copy link
Member

ricmoo commented Sep 10, 2018

Closing this, but if you have an example that fails to resolve, please feel re-open this issue.

Thanks! :)

@ricmoo ricmoo closed this as completed Sep 10, 2018
@marekkirejczyk
Copy link
Author

I have checked again. The problem was that reverse lookup result didn't point to the domain pointing to the same address.
So, all is good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Questions, feedback and general information.
Projects
None yet
Development

No branches or pull requests

2 participants