Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Add test for FindPeer #1362

Open
nonsense opened this issue Apr 30, 2019 · 0 comments
Open

Add test for FindPeer #1362

nonsense opened this issue Apr 30, 2019 · 0 comments
Labels

Comments

@nonsense
Copy link
Contributor

This should be done as part of the simple-fetchers branch.

The functionality that decides who the next eligible peer is based on a given Kademlia table is not tested thoroughly and we should add tests to it.

// FindPeer is returning the closest peer from Kademlia that a chunk
// request hasn't already been sent to
func (d *Delivery) FindPeer(ctx context.Context, req *storage.Request) (*Peer, error) {

Feel free to modify the interface of this method and suggest alternatives, but ultimately we should have good coverage on the algorithm that decides who is the next selected Peer for a given request.

@nonsense nonsense added the test label Apr 30, 2019
@zelig zelig added the stream label May 1, 2019
@nonsense nonsense mentioned this issue Jun 17, 2019
13 tasks
@acud acud removed the stream label Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants