Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Refactor swap logs with actions prefix #1788

Closed
santicomp2014 opened this issue Sep 20, 2019 · 2 comments · Fixed by #2119
Closed

Refactor swap logs with actions prefix #1788

santicomp2014 opened this issue Sep 20, 2019 · 2 comments · Fixed by #2119
Assignees
Milestone

Comments

@santicomp2014
Copy link
Contributor

In order to filter swap logs, the prefix of swap logs has to be refactored

currently swap logs are prefixed with

swap-logs "*"

This creates a conflict when searching such logs.

as @skylenet mentioned we should change the logs to use actions instead of a generic prefix.

For now I would prefer to just tag your log line like: swap.{action} e.g. swap.contractDeployed addr=1234 owner=4123. You can then easily filter the logs by those tags.

@Eknir
Copy link
Contributor

Eknir commented Feb 6, 2020

@santicomp2014 , what is the status of this issue?

@santicomp2014
Copy link
Contributor Author

3 Working days

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants