Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

refactor SWAP Params struct #1877

Open
mortelli opened this issue Oct 14, 2019 · 0 comments
Open

refactor SWAP Params struct #1877

mortelli opened this issue Oct 14, 2019 · 0 comments

Comments

@mortelli
Copy link
Contributor

mortelli commented Oct 14, 2019

To be honest Params is poorly designed and was meant as an organizing thing for economic parametrization (thresholds, cashing strategy, amounts, etc.).

We have been refactoring the Swap constructor all the time recently, that is why instead of making a huuuuuge constructor with maaaany parameters (resulting in many changes), we started adding mixed parameters to this generic Params struct.

I would like to see a refactoring of this, but it does not need to be in this PR. Conceptually OverlayAddr does not belong to this struct, but LogPath neither does.

Originally posted by @holisticode in PR #1806

@mortelli mortelli changed the title Refactor SWAP Params struct refactor SWAP Params struct Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant