Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

cmd/swarm: allow using a network interface by name for nat purposes #1557

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

skylenet
Copy link
Contributor

I didn't want to change the behaviour of the current --nat flag. Therefore I added a --natif flag.

E.g. swarm --natif eth0 will announce you with the IP address that is on the eth0 network interface.

This is specially useful when running multiple swarm nodes within docker because it will pickup the IP address of the interface during runtime. Previously I always had to wrap swarm around some shell script to magically get the IP address... which is not nice.

@skylenet skylenet requested review from nonsense, acud and janos July 11, 2019 20:49
@skylenet skylenet added this to the 0.4.3 milestone Jul 11, 2019
@skylenet skylenet merged commit ad77f43 into master Jul 16, 2019
@skylenet skylenet deleted the nat-interface branch July 23, 2019 07:37
chadsr added a commit to chadsr/swarm that referenced this pull request Sep 23, 2019
* 'master' of github.com:ethersphere/swarm: (54 commits)
  api, chunk, cmd, shed, storage: add support for pinning content (ethersphere#1509)
  docs/swarm-guide: cleanup (ethersphere#1620)
  travis: split jobs into different stages (ethersphere#1615)
  simulation: retry if we hit a collision on tcp/udp ports (ethersphere#1616)
  api, chunk: rename Tag.New to Tag.Create (ethersphere#1614)
  pss: instrumentation and refactor (ethersphere#1580)
  api, cmd, network: add --disable-auto-connect flag (ethersphere#1576)
  changelog: fix typo (ethersphere#1605)
  version: update to v0.4.4 unstable (ethersphere#1603)
  swarm: release v0.4.3 (ethersphere#1602)
  network/retrieve: add bzz-retrieve protocol (ethersphere#1589)
  PoC: Network simulation framework (ethersphere#1555)
  network: structured output for kademlia table (ethersphere#1586)
  client: add bzz client, update smoke tests (ethersphere#1582)
  swarm-smoke: fix check max prox hosts for pull/push sync modes (ethersphere#1578)
  cmd/swarm: allow using a network interface by name for nat purposes (ethersphere#1557)
  pss: disable TestForwardBasic (ethersphere#1544)
  api, network: count chunk deliveries per peer (ethersphere#1534)
  network/newstream: new stream! protocol base implementation (ethersphere#1500)
  swarm: fix bzz_info.port when using dynamic port allocation (ethersphere#1537)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants