From 84a94492613e2affece5c4f85ad1f6a01f12b14c Mon Sep 17 00:00:00 2001 From: Paul Sanders Date: Thu, 15 Dec 2022 17:13:14 -0500 Subject: [PATCH 1/2] Add log before raising error --- src/fides/api/main.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fides/api/main.py b/src/fides/api/main.py index 917e55d439..87d069f4e5 100644 --- a/src/fides/api/main.py +++ b/src/fides/api/main.py @@ -52,6 +52,7 @@ ) from fides.api.ops.tasks.scheduled.scheduler import scheduler from fides.api.ops.util.cache import get_cache +from fides.api.ops.util.logger import Pii from fides.ctl.core.config import FidesConfig, get_config from fides.ctl.core.config.helpers import check_required_webserver_config_values from fides.lib.oauth.api.routes.user_endpoints import router as user_router @@ -117,6 +118,7 @@ async def dispatch_log_request(request: Request, call_next: Callable) -> Respons await prepare_and_log_request( endpoint, request.url.hostname, 500, now, fides_source, e.__class__.__name__ ) + logger.error("An error occurred while dispatching logs: {}", Pii(str(e))) raise From 596a8106e94f55625e5de823df5a7c9f9e1e2b1a Mon Sep 17 00:00:00 2001 From: Paul Sanders Date: Thu, 15 Dec 2022 21:21:10 -0500 Subject: [PATCH 2/2] Use _log_execption function --- src/fides/api/main.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fides/api/main.py b/src/fides/api/main.py index 87d069f4e5..3cd19f1027 100644 --- a/src/fides/api/main.py +++ b/src/fides/api/main.py @@ -52,7 +52,7 @@ ) from fides.api.ops.tasks.scheduled.scheduler import scheduler from fides.api.ops.util.cache import get_cache -from fides.api.ops.util.logger import Pii +from fides.api.ops.util.logger import _log_exception from fides.ctl.core.config import FidesConfig, get_config from fides.ctl.core.config.helpers import check_required_webserver_config_values from fides.lib.oauth.api.routes.user_endpoints import router as user_router @@ -118,7 +118,7 @@ async def dispatch_log_request(request: Request, call_next: Callable) -> Respons await prepare_and_log_request( endpoint, request.url.hostname, 500, now, fides_source, e.__class__.__name__ ) - logger.error("An error occurred while dispatching logs: {}", Pii(str(e))) + _log_exception(e, CONFIG.dev_mode) raise