Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: can config the registry url #286

Closed
lolychee opened this issue Jul 23, 2020 · 4 comments · Fixed by #1621
Closed

Feature request: can config the registry url #286

lolychee opened this issue Jul 23, 2020 · 4 comments · Fixed by #1621

Comments

@lolychee
Copy link

let url = `https://registry.npmjs.org/${package}/-/${package}-${version}.tgz`

idea:
config the https://registry.npmjs.org from yarn config get registry or ENV.

@lolychee lolychee changed the title Request: can config the registry url Feature request: can config the registry url Jul 23, 2020
@evanw
Copy link
Owner

evanw commented Jul 24, 2020

Can you say why you would want to do this? Is this causing esbuild to be broken for you? The install script downloads the packages from the npm registry because the packages are only ever published to the npm registry.

@LanceZhu
Copy link

In China, can not download this package from the npmjs registry or the speed is very slow. If can config the registry url, we can download from cnpm or similar mirror site.

@Benoit-Vasseur
Copy link

Kind of related, I am behind a proxy and the request seems not to take my HTTPS_PROXY export into account.

@evanw evanw closed this as completed in 2241b21 Jul 25, 2020
@evanw
Copy link
Owner

evanw commented Jul 25, 2020

Version 0.6.6 should now respect the configured npm registry. Read the release notes for more details.

Note that I haven't fully tested this so it'd be great to get independent confirmation that it works as expected. I only verified that the configuration setting causes the download to be redirected to the new domain instead of going to the npm registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants