Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for registry Configuration #3938

Closed
elrrrrrrr opened this issue Oct 9, 2024 · 2 comments
Closed

Feature Request: Support for registry Configuration #3938

elrrrrrrr opened this issue Oct 9, 2024 · 2 comments

Comments

@elrrrrrrr
Copy link

I've noticed from the recent changes that esbuild has stopped supporting the registry configuration, which previously was able to recognize the npm_config_registry environment variable. This feature was quite useful for many users who work with private registries or need to specify a custom registry.

I've seen the discussion in issue #291, and I understand that there might be concerns about the complexity it adds to the build process. However, I believe the benefits outweigh the potential drawbacks, and it would be a valuable addition to the tool. 🙏🏻

@evanw
Copy link
Owner

evanw commented Oct 9, 2024

The way that this is supposed to work now is that esbuild just invokes npm directly instead of emulating it, and the npm command is supposed to handle everything including the npm_config_registry environment variable. This has been the case for quite some time now. You're linking to a very old issue from before esbuild started doing that (which was in version 0.6.28, not long after the issue you're referencing was closed). So this should already be working.

If you have a bug report for esbuild, then please provide reproduction instructions.

@elrrrrrrr
Copy link
Author

😯 I've noticed that the process installUsingNPM is executed first, and only if it fails will the process downloadDirectlyFromNPM continue. Thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants