Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Maven 3.1.0 #10

Closed
aldaris opened this issue Aug 20, 2013 · 60 comments
Closed

Add support for Maven 3.1.0 #10

aldaris opened this issue Aug 20, 2013 · 60 comments

Comments

@aldaris
Copy link

aldaris commented Aug 20, 2013

Currently it seems that the plugins are not yet working with Maven 3.1.0, they are failing with:

[WARNING] Error injecting: com.github.goldin.plugins.copy.CopyMojo
java.lang.NoClassDefFoundError: Lorg/sonatype/aether/RepositorySystem;
    at java.lang.Class.getDeclaredFields0(Native Method)
    at java.lang.Class.privateGetDeclaredFields(Class.java:2291)
    at java.lang.Class.getDeclaredFields(Class.java:1743)
    at com.google.inject.spi.InjectionPoint.getInjectionPoints(InjectionPoint.java:661)

This link seems to be relevant:
https://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound

@evgeny-goldin
Copy link
Owner

Hi,

Yes, it's a known issue of Sonatype deliberately breaking compatibility between Maven 3.0.x and Maven 3.1.x now forcing everyone to upgrade. I opened an issue in project's tracker: http://evgeny-goldin.org/youtrack/issue/pl-695, will address it for 0.3 release. Ideally, plugins will be able to run on both versions but if not then Maven 3.1.0 only.

@kungfujoe
Copy link

How is progress coming on this issue?

@cforce
Copy link

cforce commented Sep 26, 2013

Also waitig for this--

@dimgit
Copy link

dimgit commented Oct 15, 2013

I am also waiting for this

@jeslopalo
Copy link

Please, I also need it!

Thank you very much!

@Loki-Afro
Copy link

I am also very interrested in this.

@SimonKaluza
Copy link

This would be very beneficial for me as well 👍

@bbqrob
Copy link

bbqrob commented Nov 25, 2013

Any progress so far?

@ptahchiev
Copy link

I'm also waiting on this one :)

@evgeny-goldin
Copy link
Owner

Hi guys, sorry to keep you waiting, been busy with other projects. I plan a release of 0.3 version having this issue addressed to the second half of December.

@bbqrob
Copy link

bbqrob commented Jan 2, 2014

Hi Evgeny,

any news on this issue?

Regs,
Rob

@arekrob
Copy link

arekrob commented Jan 4, 2014

I am also waiting for a fix. Is there any progress?

@ptahchiev
Copy link

Any updates on this one?

@dhsmith1001
Copy link

I love the copy-maven-plugin. We have run into the 3.1 compatibility issue. Waiting for a fix. Thanks!

@liebsche
Copy link

I'm also waiting for a relase with Maven 3.1 support. What about the December promise!?

@liberzon
Copy link

I'm also waiting for this fix.

@r0b-
Copy link

r0b- commented Jan 20, 2014

Any updates? We also like to use Maven 3.1
Great plugin btw 👍

@mitjanikolaus
Copy link

I'm also very interested because travis is using maven 3.1.

@lloydwatkin
Copy link

This will please the people using Travis ...

buddycloud/buddycloud-server-java@2c11fd2

@thunderland
Copy link

Is this project still alive? Is there an alternative to this plugin in maven-3.1.1?

@ptahchiev
Copy link

The most frustrating of all is that it should be literally a 5-minute change:

https://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound

@lloydwatkin
Copy link

I'm not familiar with maven/java to do this myself but there's lots of complaints and no pull requests. I'm sure if one where there the author would happily merge and deploy.

@aldaris
Copy link
Author

aldaris commented Jan 23, 2014

I've actually had a look at the code, but building the project itself was proving to be a challenge, and then I also had to realize, that some of the Aether dependent code is written in Groovy, so I admit I just simply gave up. :(

@asafm
Copy link

asafm commented Jan 23, 2014

Got this now as well!

@bbqrob
Copy link

bbqrob commented Jan 23, 2014

I'm absolutely not into Groovy, but I don't think that's a minor change to make this work. After editing the code a bit, I found my maven build terminating with this error:

[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import from realm ClassRealm[maven.api, parent: null]]
[ERROR]
[ERROR] -----------------------------------------------------: org.sonatype.aether.RepositorySystem
[ERROR] -> [Help 1]

Don't know, if anyone got an idea here.

@evgeny-goldin-akqa
Copy link

Sorry folks for not being able to address this issue. No, it's not a 5-minute change, I can guarantee you that - I've accessed various private Aether fields in Groovy (since its API is so limited that it left no other way) and in the new version all these access points need to be reviewed and tested, something I can not allocate time for right now. Feel free to ping me at evgenyg@gmail.com with any build issues, it should be a very straightforward process. It would be nice if one of you just forks the project as I'll surely have no time to go through all the tests (https://github.com/evgeny-goldin/maven-plugins-test) if they fail after the pull-request, if one is made. I understand it can be painful for some of you but I'm not able to support this project at this point as I've moved as far away from Maven as I could.

@vmassol
Copy link

vmassol commented Sep 12, 2014

Same problem here... Any update to fix this issue?

@tcollignon
Copy link

+1 same problem, have you a plan for this correction ? We can test something if you want
Thank in advance

@fpompermaier
Copy link

+1

1 similar comment
@jboesl
Copy link

jboesl commented Nov 14, 2014

+1

VeraGiannaki added a commit to VeraGiannaki/maven-plugins that referenced this issue Nov 18, 2014
* Changed maven version to 3.2.2
* Remove enforcer rule for maven version 3.0.5
* Replace aether sonatype with eclipse (evgeny-goldin#10)
* Replace sonatype aether packages in src code with the eclipse packages
* Change enforcer plugin to version 1.3 to be compatible with mave 3.2 (https://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound)

Note: Silencer plugin is not configured to run while building the maven
plugins anymore, since previous version of the plugin is not compatible
with the new one.
@cmark
Copy link

cmark commented Nov 27, 2014

+1

@asafm
Copy link

asafm commented Jan 6, 2015

Just wanted to let you know I managed to the same functionality I needed from this plugin using the following plugins:

                <groupId>org.codehaus.mojo</groupId>
                <artifactId>build-helper-maven-plugin</artifactId>

Also I've seen that this plugin can run scripts written in Beanshell and also supports Groovy.
So I'm done with this plugin :)

@jboesl
Copy link

jboesl commented Feb 21, 2015

I made another fork which now supports maven 3.0, 3.1 and upwards. It's available at https://github.com/jboesl/maven-plugins.
But as far as I can see the documentation is no longer available. If anyone has it still around I'd add it to the sources.

@tcollignon
Copy link

Can you provide a pull request please? It will be fix this repo too. Thanks a lot for your work !

@jboesl
Copy link

jboesl commented Feb 24, 2015

I fixed line endings too so there are quite a lot diffs in the pull request. I don't think that pull request would be accepted.

@tcollignon
Copy link

Oh I see. Can you provide another pull request with only fix for Maven?

@jboesl
Copy link

jboesl commented Feb 24, 2015

That's difficult because I'm on linux and am having problems with the line endings in this project.

@tcollignon
Copy link

I will try this so

@seanf
Copy link

seanf commented Feb 24, 2015

The WayBack machine seems to have the documentation: http://wayback.archive.org/web/20140707025424/http://evgeny-goldin.com/wiki/Maven_Plugins

@tcollignon
Copy link

It's done here : #21
I hope this will be merged, and why not released new version of plugins.
Thanks again for the job, @jboesl

@jboesl
Copy link

jboesl commented Feb 24, 2015

Thanks seanf. I added a copy of the documentation to the sources.

@Antibrumm
Copy link

For those not wanting to build their own plugin I started a new copy-maven-plugin here: https://github.com/Antibrumm/copy-maven-plugin
The plugin version 0.0.1 should be released on maven central within a day or two. It's already released on to the sonatype nexus.

It's heavily inspired by this great plugin here, but works only on local content and is written in plain java as I did not understand fully the groovy setup of maven-plugins :)

Before I was using the properties-maven-plugin and the copy-maven-plugin:
The properties plugin I was able to replace with the gmavenplus-plugin and for the dependency copying I use now the maven-dependency-plugin with the unpack goal before I run my own copy-maven-plugin.

@tcollignon
Copy link

Thanks @Antibrumm , it will be great to have a new maintener of this very good plugin !

@Lonzak
Copy link

Lonzak commented Jul 22, 2015

Can anybody give me an update on the state of the plugin? Is the original plugin (0.3-SNAPSHOT) bugfixed for maven 3.1? I can't use the fork of antibrumm since it requires java 1.8 and maven 3.2+

@jboesl
Copy link

jboesl commented Jul 22, 2015

Afaik evgeny-goldin has no plans to continue this project. There are forks that work with current maven versions like mine but those forks are not available at maven-central.

@Lonzak
Copy link

Lonzak commented Jul 22, 2015

Your version fixed some more stuff (line endings) - how does it effect the usage? Where and how is this relevant? Does it effect the plugin in anyway on different operating systems like windows? Does your version has the same requirements regarding the java and the maven version like the original plugin?

@jboesl
Copy link

jboesl commented Jul 22, 2015

  1. Doesn't affect usage.
  2. It is relevant when you use git for working on the source.
  3. No.
  4. Yes.

@Lonzak
Copy link

Lonzak commented Jul 22, 2015

Sounds good :-) Two last questions: 1) Which version should be used? 0.3-beta-1 or 0.2.6-beta-2?
2) Its not on maven central but is it available in any other repo? If so where?

@jboesl
Copy link

jboesl commented Jul 22, 2015

  1. None of those. There is no relased verison of it. You've got to use the latest sources.
  2. Well there is my own private repository but that's of no use here. There is no other repository I know of where it's available.

Since there seem to be quite some people interested on that plugin maybe we should ask evgeny-goldin how the work should be continued. I'll look into that.

@jboesl
Copy link

jboesl commented Nov 13, 2015

I think we shouldn't abuse this ticket for stuff that doesn't belong here. If you encounter issues with the fork please create an issue over there.

@jteche
Copy link

jteche commented May 30, 2016

i was using the goldin plugin to copy the resource from one to other location and was getting the same issue in maven 3.1.x or 3.2.x . If anybody is/was using the goldin for same purpose there is one alternative to use maven-resources-plugin to achieve the same via copy-resources. more details on it is available on http://stackoverflow.com/questions/19409220/copying-multiple-resource-directories-to-independent-target-directories-with-mav.

@JLLeitschuh
Copy link

We're using the properties-maven-plugin and this problem still exists.
Is there any new version of this plugin under some other namespace that I can depend upon that works in new versions of maven?

steghoja pushed a commit to steghoja/synligare that referenced this issue May 6, 2017
The original plugin to copy resources no longer works with Maven 3.1 and above:
evgeny-goldin/maven-plugins#10

Instead, a replacement is used that can, however, not unpack ZIP files:
https://github.com/Antibrumm/copy-maven-plugin

For unpacking, a separate plugin is employed.
@aldaris aldaris closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests