From 2470802e8a1c2870cf39037e4b7274248418148b Mon Sep 17 00:00:00 2001 From: Ramiro Carlucho Date: Wed, 14 Sep 2022 10:35:04 +0100 Subject: [PATCH] format error on EstimateGas rpc call --- rpc/backend/call_tx.go | 6 ++++++ tests/integration_tests/test_types.py | 2 ++ 2 files changed, 8 insertions(+) diff --git a/rpc/backend/call_tx.go b/rpc/backend/call_tx.go index 96932f92c0..44b027b7f3 100644 --- a/rpc/backend/call_tx.go +++ b/rpc/backend/call_tx.go @@ -303,6 +303,12 @@ func (b *Backend) EstimateGas(args evmtypes.TransactionArgs, blockNrOptional *rp GasCap: b.RPCGasCap(), } + _, err = b.TendermintBlockByNumber(blockNr) + if err != nil { + // the error message imitates geth behavior + return 0, errors.New("header not found") + } + // From ContextWithHeight: if the provided height is 0, // it will return an empty context and the gRPC query will use // the latest block height for querying. diff --git a/tests/integration_tests/test_types.py b/tests/integration_tests/test_types.py index afc9dd9646..0318317dc1 100644 --- a/tests/integration_tests/test_types.py +++ b/tests/integration_tests/test_types.py @@ -313,6 +313,8 @@ def test_estimate_gas(ethermint, geth): eth_rpc = ethermint.w3.provider geth_rpc = geth.w3.provider make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx]) + make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx, "0x0"]) + make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [tx, "0x5000"]) make_same_rpc_calls(eth_rpc, geth_rpc, "eth_estimateGas", [{}])