From b60999440227b59d1e0fa6c895bdac86f02593eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Mon, 27 Jun 2022 12:05:24 +0200 Subject: [PATCH 1/5] release: v0.17.0 changelog (#1153) * release: v0.17.0 changelog * rm newline * update link --- CHANGELOG.md | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9aefd6c923..1bb1b502d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,12 +36,12 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog -## Unreleased +## [v0.17.0] - 2022-06-27 ### State Machine Breaking -* (evm) [\#1128](https://github.com/tharsis/ethermint/pull/1128) Clear tx logs if tx failed in post processing hooks -* (evm) [\#1124](https://github.com/tharsis/ethermint/pull/1124) Reject non-replay-protected tx in `AnteHandler` to prevent replay attack +* (evm) [\#1128](https://github.com/evmos/ethermint/pull/1128) Clear tx logs if tx failed in post processing hooks +* (evm) [\#1124](https://github.com/evmos/ethermint/pull/1124) Reject non-replay-protected tx in `AnteHandler` to prevent replay attack ### API Breaking @@ -52,15 +52,23 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Improvements * (deps) [\#1147](https://github.com/evmos/ethermint/pull/1147) Bump Go version to `1.18`. -* (feemarket) [\#1120](https://github.com/evmos/ethermint/pull/1120) Make `min-gas-multiplier` parameter accept zero value * (feemarket) [\#1135](https://github.com/evmos/ethermint/pull/1135) Set lower bound of base fee to min gas price param * (evm) [\#1142](https://github.com/evmos/ethermint/pull/1142) Rename `RejectUnprotectedTx` to `AllowUnprotectedTxs` for consistency with go-ethereum. ### Bug Fixes -* (evm) [\#1118](https://github.com/evmos/ethermint/pull/1118) Fix `Type()` `Account` method `EmptyCodeHash` comparison * (rpc) [\#1138](https://github.com/evmos/ethermint/pull/1138) Fix GasPrice calculation with relation to `MinGasPrice` +## [v0.16.1] - 2022-06-09 + +### Improvements + +* (feemarket) [\#1120](https://github.com/evmos/ethermint/pull/1120) Make `min-gas-multiplier` parameter accept zero value + +### Bug Fixes + +* (evm) [\#1118](https://github.com/evmos/ethermint/pull/1118) Fix `Type()` `Account` method `EmptyCodeHash` comparison + ## [v0.16.0] - 2022-06-06 ### State Machine Breaking From a956da20ed8a26d7c5129159e4b84ca9d89dcea9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Mon, 27 Jun 2022 15:28:19 +0200 Subject: [PATCH 2/5] fix(ci): update goreleaser, slither, mdlink --- .github/workflows/goreleaser.yml | 27 ++++++++++--------- .github/workflows/lint.yml | 9 +++++++ .github/workflows/markdown-link.yml | 20 +++++++++++++++ .github/workflows/slither.yml | 40 +++++++++++++++++++++++++++++ 4 files changed, 84 insertions(+), 12 deletions(-) create mode 100644 .github/workflows/markdown-link.yml create mode 100644 .github/workflows/slither.yml diff --git a/.github/workflows/goreleaser.yml b/.github/workflows/goreleaser.yml index 1bda08f33d..07e48883dc 100644 --- a/.github/workflows/goreleaser.yml +++ b/.github/workflows/goreleaser.yml @@ -4,25 +4,28 @@ on: push: tags: - "v*.*.*" +permissions: + contents: read + jobs: goreleaser: + permissions: + contents: write # for goreleaser/goreleaser-action to create a GitHub release runs-on: ubuntu-latest - environment: release steps: - - uses: actions/checkout@v3 + - name: Checkout + uses: actions/checkout@v3 with: - submodules: true - - name: Set up Go + fetch-depth: 0 + - name: Install Go uses: actions/setup-go@v3 with: go-version: 1.18 - check-latest: true - - name: release dry run - run: make release-dry-run - - name: setup release environment + - name: Unshallow + run: git fetch --prune --unshallow + - name: Create release + uses: goreleaser/goreleaser-action@v3 + with: + args: release --rm-dist env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: |- - echo 'GITHUB_TOKEN=${{secrets.GITHUB_TOKEN}}' > .release-env - - name: release publish - run: make release \ No newline at end of file diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d6e06dfc6f..f0345669e5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -45,3 +45,12 @@ jobs: - uses: articulate/actions-markdownlint@v1.1.0 # Check only if there are differences in the source code if: env.GIT_DIFF + solhint: + name: runner / solhint + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + - run: npm install -g solhint + - run: solhint --version + - run: solhint '**/**.sol' diff --git a/.github/workflows/markdown-link.yml b/.github/workflows/markdown-link.yml new file mode 100644 index 0000000000..0fe188e4d7 --- /dev/null +++ b/.github/workflows/markdown-link.yml @@ -0,0 +1,20 @@ +name: Check Markdown links +on: + pull_request: + paths: + - '**.md' + push: + branches: + - main + paths: + - '**.md' + +jobs: + markdown-link-check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: gaurav-nelson/github-action-markdown-link-check@master + with: + folder-path: "docs" + use-quiet-mode: "yes" diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml new file mode 100644 index 0000000000..80ee2962d4 --- /dev/null +++ b/.github/workflows/slither.yml @@ -0,0 +1,40 @@ +name: Slither Analysis + +on: + pull_request: + push: + branches: + - main + +jobs: + analyze: + name: Run Slither + runs-on: ubuntu-latest + permissions: + contents: read + security-events: write + steps: + - name: Checkout repository + uses: actions/checkout@v3 + - name: Get Diff + uses: technote-space/get-diff-action@v6.1.0 + with: + PATTERNS: | + **/*.sol + - name: Node dependencies Install + run: | + cd contracts && npm i + cp -r node_modules/@openzeppelin . + - name: Run Slither Action + uses: crytic/slither-action@v0.1.1 + continue-on-error: true + id: slither + with: + sarif: slither.sarif + target: contracts/ + if: "env.GIT_DIFF" + - name: Upload SARIF file + uses: github/codeql-action/upload-sarif@v2 + with: + sarif_file: ${{ steps.slither.outputs.sarif }} + if: "env.GIT_DIFF" From 35de636da2e0fd2ac226216484f2a4f69f2b18b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Mon, 27 Jun 2022 15:31:11 +0200 Subject: [PATCH 3/5] only check specs --- .github/workflows/markdown-link.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-link.yml b/.github/workflows/markdown-link.yml index 0fe188e4d7..29e9957830 100644 --- a/.github/workflows/markdown-link.yml +++ b/.github/workflows/markdown-link.yml @@ -16,5 +16,5 @@ jobs: - uses: actions/checkout@v3 - uses: gaurav-nelson/github-action-markdown-link-check@master with: - folder-path: "docs" + folder-path: "x" use-quiet-mode: "yes" From dd06a7db78afb50ebe5b3629e019c826c2b40a09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Mon, 27 Jun 2022 15:34:34 +0200 Subject: [PATCH 4/5] rm slither --- .github/workflows/slither.yml | 40 ----------------------------------- 1 file changed, 40 deletions(-) delete mode 100644 .github/workflows/slither.yml diff --git a/.github/workflows/slither.yml b/.github/workflows/slither.yml deleted file mode 100644 index 80ee2962d4..0000000000 --- a/.github/workflows/slither.yml +++ /dev/null @@ -1,40 +0,0 @@ -name: Slither Analysis - -on: - pull_request: - push: - branches: - - main - -jobs: - analyze: - name: Run Slither - runs-on: ubuntu-latest - permissions: - contents: read - security-events: write - steps: - - name: Checkout repository - uses: actions/checkout@v3 - - name: Get Diff - uses: technote-space/get-diff-action@v6.1.0 - with: - PATTERNS: | - **/*.sol - - name: Node dependencies Install - run: | - cd contracts && npm i - cp -r node_modules/@openzeppelin . - - name: Run Slither Action - uses: crytic/slither-action@v0.1.1 - continue-on-error: true - id: slither - with: - sarif: slither.sarif - target: contracts/ - if: "env.GIT_DIFF" - - name: Upload SARIF file - uses: github/codeql-action/upload-sarif@v2 - with: - sarif_file: ${{ steps.slither.outputs.sarif }} - if: "env.GIT_DIFF" From cc39f1b81299d3bbbe0ee558c2556e21267d730b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Mon, 27 Jun 2022 15:52:05 +0200 Subject: [PATCH 5/5] update solhint --- .github/workflows/lint.yml | 11 +++++++++- .solhint.json | 3 +++ starport.yml | 45 -------------------------------------- 3 files changed, 13 insertions(+), 46 deletions(-) create mode 100644 .solhint.json delete mode 100644 starport.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index f0345669e5..0708ee0776 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -50,7 +50,16 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 + - uses: technote-space/get-diff-action@v6.1.0 + with: + PATTERNS: | + **/**.sol - uses: actions/setup-node@v3 + # Check only if there are differences in the source code + if: env.GIT_DIFF - run: npm install -g solhint - - run: solhint --version + # Check only if there are differences in the source code + if: env.GIT_DIFF - run: solhint '**/**.sol' + # Check only if there are differences in the source code + if: env.GIT_DIFF diff --git a/.solhint.json b/.solhint.json new file mode 100644 index 0000000000..d7c3de9895 --- /dev/null +++ b/.solhint.json @@ -0,0 +1,3 @@ +{ + "extends": "solhint:default" +} diff --git a/starport.yml b/starport.yml deleted file mode 100644 index 4d3cd1b0f5..0000000000 --- a/starport.yml +++ /dev/null @@ -1,45 +0,0 @@ -accounts: - - name: alice - coins: ["100000000uatom", "100000000000000000000aphoton"] - - name: bob - coins: ["5000000000000aphoton"] - - name: faucet - coins: ["1000000000000000000000000000aphoton"] -validator: - name: alice - staked: "100000000000000000000aphoton" -faucet: - port: 4500 - name: "faucet" - coins: ["1000000000000000000000000000aphoton"] - coins_max: ["100000000aphoton"] -build: - binary: "ethermintd" -init: - home: "$HOME/.ethermintd" - app: - api: - enable: true - json-rpc: - address: "0.0.0.0:8545" # change the JSON-RPC address and port - ws-address: "0.0.0.0:8546" # change the JSON-RPC websocket address and port -genesis: - chain_id: "ethermint_9000-1" - app_state: - staking: - params: - bond_denom: "aphoton" - mint: - params: - mint_denom: "aphoton" - crisis: - constant_fee: - denom: "aphoton" - gov: - deposit_params: - min_deposit: - - amount: "10000000" - denom: "aphoton" - evm: - params: - evm_denom: "aphoton"