-
Notifications
You must be signed in to change notification settings - Fork 563
fix(tests): make integration tests more consistent #1494
Conversation
@ramacarlucho is this a duplicate from #1488? Can you explain the different approaches |
@fedekunze most of the tests are failing because we are waiting for a tx receipt on a failed send tx (even on that pr). So this is an attempt to solve that issue. i think both prs are trying to solve the same issue. I still have some inconsistency in some tests, that im trying to figure out |
@yihuang do you know what is causing this response in the following bit of code? ethermint/tests/integration_tests/test_grpc_only.py Lines 53 to 66 in 20094cd
Contract deployment should not be faling, so i dont understand the empty response. |
and the gas_used is weird. |
Seems retry could help to alleviate the gap.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion. The test_cosmovisor_upgrade
is still failing with a timeout error, for some reason it looks like blocks aren't being produced past a certain point?
f339dc3
to
632a0d6
Compare
@ramacarlucho @adisaran64 can you fix the conflicts? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
Closes: #XXX
Description
Integration tests are not stable enough.
Instead of waiting for tx receipts, attempt to resend tx a couple of times.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)