Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(evm): fix gRPC-only chain-id #1510

Closed
wants to merge 2 commits into from

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 29, 2022

Closes: ENG-1106

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@linear
Copy link

linear bot commented Nov 29, 2022

ENG-1106 grpc_only test are failing when querying contracts deployed from another node

@ramirocarlucho found this issue when trying to fix the grpc_only integration test reliability.

The test deploys a contract that has one simple function that returns the chain id. The contract gets deployed on Node 0 and then the query is made on Node 1.

When this happens what we are seeing is that ~50% of the time, the chainId is not returned under this conditions. Once a contract is deployed and the issue is reproduced, the call will ALWAYS fail for that specific contract. And if its succesfull, its ALWAYS succesful for that contract. So it seems to be something related to the deployment of the contract.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1510 (40a02f7) into main (a5c927b) will increase coverage by 0.01%.
The diff coverage is 92.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   68.73%   68.74%   +0.01%     
==========================================
  Files         103      104       +1     
  Lines        9948     9961      +13     
==========================================
+ Hits         6838     6848      +10     
- Misses       2730     2732       +2     
- Partials      380      381       +1     
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 77.68% <ø> (-4.26%) ⬇️
x/evm/keeper/config.go 90.47% <90.47%> (ø)
x/evm/keeper/grpc_query.go 85.93% <100.00%> (+0.03%) ⬆️
x/evm/keeper/utils.go 84.28% <100.00%> (+1.20%) ⬆️

@fedekunze
Copy link
Contributor Author

closing as it doesn't fix the issue. I'll create a new ticket for the refactor

@fedekunze fedekunze closed this Nov 30, 2022
@fedekunze fedekunze deleted the fedekunze/fix-grpc-only-chain-id branch November 30, 2022 14:05
@mmsqe mmsqe mentioned this pull request Dec 9, 2022
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant