From a8d8dee536b63408dd5a19fcab277f19fae3e55e Mon Sep 17 00:00:00 2001 From: Loredana Date: Sun, 6 Mar 2022 15:16:14 +0200 Subject: [PATCH 1/2] Quick fix for eth_feeHistory when reward is nil `RPC method eth_feeHistory crashed: runtime error: invalid memory address or nil pointer dereference` from https://github.com/tharsis/ethermint/blob/caa1c5a6c6b7ed8ba4aaf6e0b0848f6be5ba6668/rpc/ethereum/backend/feebackend.go#L29 --- rpc/ethereum/backend/feebackend.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rpc/ethereum/backend/feebackend.go b/rpc/ethereum/backend/feebackend.go index b09b5d421b..ed44833aca 100644 --- a/rpc/ethereum/backend/feebackend.go +++ b/rpc/ethereum/backend/feebackend.go @@ -87,6 +87,9 @@ func (e *EVMBackend) processBlock( } tx := ethMsg.AsTransaction() reward := tx.EffectiveGasTipValue(blockBaseFee) + if reward == nil { + reward = big.NewInt(0) + } sorter[i] = txGasAndReward{gasUsed: txGasUsed, reward: reward} break } From 62d9597130c4359c8335d5f7997943aa7affb2ae Mon Sep 17 00:00:00 2001 From: Loredana Date: Sun, 6 Mar 2022 15:25:19 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30bfa1358b..19e51ec424 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes +* (rpc) [\#529](https://github.com/tharsis/ethermint/pull/975) Fix unexpected `nil` values for `reward`, returned by `EffectiveGasTipValue(blockBaseFee)` in the `eth_feeHistory` RPC method. * (evm) [\#529](https://github.com/tharsis/ethermint/issues/529) Add support return value on trace tx response. * (rpc) [#970] (https://github.com/tharsis/ethermint/pull/970) Fix unexpected nil reward values on `eth_feeHistory` response