Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/exception-in-console #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sankarngrjn
Copy link

@sankarngrjn sankarngrjn commented Nov 24, 2024

Previously, when passing rich_console in context_settings, all outputs except exceptions were rendered under the provided console. This caused inconsistencies in the output format, as exceptions would bypass the rich console, leading to a mismatch in styling or behavior.

This change ensures that exceptions are also captured and displayed within the provided rich_console. By addressing this, all outputs, including exceptions, will now conform to the same console formatting, maintaining consistency across the board.

Ref. Past
1
2

Ref. Present
3

Copy link
Collaborator

@dwreeves dwreeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your PR. Your description of the issue makes sense, although I have one note on the test changes.

tests/test_config.py Outdated Show resolved Hide resolved
@dwreeves
Copy link
Collaborator

dwreeves commented Nov 25, 2024

Thanks for the change! It seems correct to me looking at the code, but I'll need to manually test before merging. A simple reproducible example will help with that, otherwise I'll make my own example and review the change on my own time (hopefully end of this week?).

Don't worry about adding a unit test if you don't want to because we need to eventually revamp the entire testing approach, so until then we are OK with no coverage. Just an example works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants