From cc01b1521b2baf43a73c4835ac40a19b6890716f Mon Sep 17 00:00:00 2001 From: "A.Juneja" Date: Mon, 24 Jan 2022 15:37:46 +0530 Subject: [PATCH 1/2] updating code doc --- lib/ex_aws/s3.ex | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ex_aws/s3.ex b/lib/ex_aws/s3.ex index a99eb42..e93d1c2 100644 --- a/lib/ex_aws/s3.ex +++ b/lib/ex_aws/s3.ex @@ -1222,10 +1222,10 @@ defmodule ExAws.S3 do When option param `:s3_accelerate` is `true`, the bucket name will be used as the hostname, along with the `s3-accelerate.amazonaws.com` host. - When option param `:bucket_as_host` is `true`, the bucket name will be used as - the hostname, which will look like `..com` host. + When option param :bucket_as_host is true, the bucket name will be used as the full hostname. + In this case, bucket must be set to a full hostname, for example `mybucket.example.com`. The `bucket_as_host` must be passed along with `virtual_host=true` - + Additional (signed) query parameters can be added to the url by setting option param `:query_params` to a list of `{"key", "value"}` pairs. Useful if you are uploading parts of a multipart upload directly from the browser. From f89b7cfb50b58f9f0e85ac35999888b7fe038112 Mon Sep 17 00:00:00 2001 From: "A.Juneja" Date: Mon, 24 Jan 2022 18:28:40 +0530 Subject: [PATCH 2/2] update --- lib/ex_aws/s3.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ex_aws/s3.ex b/lib/ex_aws/s3.ex index e93d1c2..24f3a4d 100644 --- a/lib/ex_aws/s3.ex +++ b/lib/ex_aws/s3.ex @@ -1222,7 +1222,7 @@ defmodule ExAws.S3 do When option param `:s3_accelerate` is `true`, the bucket name will be used as the hostname, along with the `s3-accelerate.amazonaws.com` host. - When option param :bucket_as_host is true, the bucket name will be used as the full hostname. + When option param `:bucket_as_host` is `true`, the bucket name will be used as the full hostname. In this case, bucket must be set to a full hostname, for example `mybucket.example.com`. The `bucket_as_host` must be passed along with `virtual_host=true`