Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose variable window.EXCALIDRAW_ASSET_PATH to allow host define the path for excalidraw assets #3068

Merged
merged 10 commits into from
Feb 21, 2021

Conversation

ad1992
Copy link
Member

@ad1992 ad1992 commented Feb 20, 2021

CSB is also working now, no more chunk errors 🎉 try here

No more webpack_public_path needed explicitly in the host and it will default to unpkg CDN if window.EXCALIDRAW_ASSET_PATH is not defined.

for #3061, #3013, #3060

I had tried this approach earlier but unfortunately, I was assigning webpack_public_path at the wrong place in entry.js :/.

This will make hosting the excalidraw assets for the host much easier as its now scoped down to just Excalidraw.

TODOS

  • Test in non CRA
  • Test in CRA
  • Append content hash to excalidraw-assets so cache bursting happens when version update
  • update changelog and readme
  • Release version v0.4.0 🎉

…ne the path for excalidraw assets

No more __webpack_public_path__ needed explicitly in host and it will default to unpkg cdn if window.EXCALIDRAW_ASSET_PATH is not defined
@vercel
Copy link

vercel bot commented Feb 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/CW2cEz6j2mhkgGwneGuj2z4PW8J7
✅ Preview: https://excalidraw-git-aakansha-asset-excalidraw.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants