-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose variable window.EXCALIDRAW_ASSET_PATH to allow host define the path for excalidraw assets #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne the path for excalidraw assets No more __webpack_public_path__ needed explicitly in host and it will default to unpkg cdn if window.EXCALIDRAW_ASSET_PATH is not defined
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/CW2cEz6j2mhkgGwneGuj2z4PW8J7 |
dwelle
reviewed
Feb 20, 2021
dwelle
approved these changes
Feb 20, 2021
…en version update
dwelle
approved these changes
Feb 21, 2021
This was referenced Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSB is also working now, no more chunk errors 🎉 try here
No more webpack_public_path needed explicitly in the host and it will default to unpkg CDN if window.EXCALIDRAW_ASSET_PATH is not defined.
for #3061, #3013, #3060
I had tried this approach earlier but unfortunately, I was assigning webpack_public_path at the wrong place in
entry.js
:/.This will make hosting the excalidraw assets for the host much easier as its now scoped down to just Excalidraw.
TODOS