Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint(validators): add missing context #214

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Mar 11, 2021

Before this commit, if a track had a JSON file containing a
whitespace-only string, such as:

{
  "files": {
    "solution": [" "],
    "test": ["test_foo.nim"],
    "exemplar": [".meta/exemplar.nim"]
  }
}

the previous output of configlet lint would contain:

    Array contains whitespace-only string: 'solution'

This commit adds the missing context, so that the output of
configlet lint would now contain:

    Array contains whitespace-only string: 'files.solution'

@ee7 ee7 force-pushed the lint-validators-add-missing-context branch from 23a295e to 5838201 Compare March 11, 2021 10:48
@ee7
Copy link
Member Author

ee7 commented Mar 11, 2021

(Ignore the force-push - I pushed to the wrong branch).

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

For a .meta/config.json containing
```json
{
  "files": {
    "solution": [" "],
    "test": ["test_foo.nim"],
    "exemplar": [".meta/exemplar.nim"]
  }
}
```

Before this commit:
    Array contains whitespace-only string: 'solution'

With this commit:
    Array contains whitespace-only string: 'files.solution'
@ee7 ee7 force-pushed the lint-validators-add-missing-context branch from 5838201 to 4963ffa Compare March 11, 2021 13:27
@ee7 ee7 merged commit 205825f into exercism:main Mar 11, 2021
@ee7 ee7 deleted the lint-validators-add-missing-context branch March 11, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants