lint: extract required file checks to modules #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation that checked if required files were present was done in the `lint.nim` file. To better separate concerns, these file checks have been moved to their own modules. The validation helper proc to check for required files has been moved to the validators module.
ErikSchierboom
approved these changes
Mar 17, 2021
|
Just as a reminder to myself: this PR is an example of some bizarre GitHub behaviour. This happened:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation that checked if required files were present was done in
the
lint.nimfile. To better separate concerns, these file checks havebeen moved to their own modules.
The validation helper proc to check for required files has been moved to
the validators module.
This commit is from #219 - let's merge this refactoring separately, just to lower the number of commits merged as "rebase and merge" from a single PR.