Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint(track_config): check status and online_editor #235

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Mar 24, 2021

From the spec:

  • The "status.concept_exercises" key is required
  • The "status.concept_exercises" value must be a boolean
  • The "status.test_runner" key is required
  • The "status.test_runner" value must be a boolean
  • The "status.representer" key is required
  • The "status.representer" value must be a boolean
  • The "status.analyzer" key is required
  • The "status.analyzer" value must be a boolean
  • The "online_editor.indent_style" key is required
  • The "online_editor.indent_style" value must be the string space or tab
  • The "online_editor.indent_size" key is required
  • The "online_editor.indent_size" value must be a positive integer (>= 0)

Diff due to this PR to the current tracks:

dart

Used "online_editor": null, - see here

+Not an object: 'online_editor':
+./config.json
+

research_experiment_1

+Missing key: 'status':
+./config.json
+
+Missing key: 'online_editor':
+./config.json
+

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

research_experiment_1

FYI: you can ignore this repo from your diffs, as it is not really a track repo

@ee7
Copy link
Member Author

ee7 commented Mar 24, 2021

research_experiment_1

FYI: you can ignore this repo from your diffs, as it is not really a track repo

Sure - it's just there because I use every repo tagged with exercism_track so that I don't have to update some hardcoded list when we add a new track.

@ee7 ee7 force-pushed the lint-track-config-status-and-online-editor branch from f2464a1 to e2231c8 Compare March 24, 2021 12:13
@ee7
Copy link
Member Author

ee7 commented Mar 24, 2021

Made a quick fix because the below was ugly, and looked like a float:

The value of `online_editor.indent_size` is `-5`, but it must be an integer >= 0.:
./config.json

@ee7 ee7 merged commit 3d19f64 into exercism:main Mar 24, 2021
@ee7 ee7 deleted the lint-track-config-status-and-online-editor branch March 24, 2021 13:03
@ee7 ee7 mentioned this pull request Mar 26, 2021
ee7 added a commit that referenced this pull request Mar 26, 2021
This commit adds `status`, `online_editor`, and `key_features` to the
success message.

These changes should have been included in:
- 3d19f64 (#235)
- fb47121 (#236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants